linux-kernel - Re: [PATCH] crypto: inside-secure - Fix the return value of safexcel_xcbcmac_cra

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b4fd8b58-1736-d2ef-0c81-6cb97a7987d4@huawei.com>
Date: Thu, 7 Nov 2024 09:18:33 +0800
From: Li Huafei <lihuafei1@...wei.com>
To: Antoine Tenart <atenart@...nel.org>, <davem@...emloft.net>,
	<herbert@...dor.apana.org.au>, <pliem@...linear.com>
CC: <linux-crypto@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] crypto: inside-secure - Fix the return value of
 safexcel_xcbcmac_cra_init()



On 2024/11/6 0:00, Antoine Tenart wrote:
> Quoting Li Huafei (2024-10-31 12:27:55)
>> The commit 320406cb60b6 ("crypto: inside-secure - Replace generic aes
>> with libaes") replaced crypto_alloc_cipher() with kmalloc(), but did not
>> modify the handling of the return value. When kmalloc() returns NULL,
>> PTR_ERR_OR_ZERO(NULL) returns 0, but in fact, the memory allocation has
>> failed, and -ENOMEM should be returned.
>>
>> Fixes: 320406cb60b6 ("crypto: inside-secure - Replace generic aes with libaes")
>> Signed-off-by: Li Huafei <lihuafei1@...wei.com>
> 
> Acked-by: Antoine Tenart <atenart@...nel.org>
> 
> Thanks!
> 

Thank you for reviewing.

>> ---
>>  drivers/crypto/inside-secure/safexcel_hash.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/crypto/inside-secure/safexcel_hash.c b/drivers/crypto/inside-secure/safexcel_hash.c
>> index e17577b785c3..f44c08f5f5ec 100644
>> --- a/drivers/crypto/inside-secure/safexcel_hash.c
>> +++ b/drivers/crypto/inside-secure/safexcel_hash.c
>> @@ -2093,7 +2093,7 @@ static int safexcel_xcbcmac_cra_init(struct crypto_tfm *tfm)
>>  
>>         safexcel_ahash_cra_init(tfm);
>>         ctx->aes = kmalloc(sizeof(*ctx->aes), GFP_KERNEL);
>> -       return PTR_ERR_OR_ZERO(ctx->aes);
>> +       return ctx->aes == NULL ? -ENOMEM : 0;
>>  }
>>  
>>  static void safexcel_xcbcmac_cra_exit(struct crypto_tfm *tfm)
>> -- 
>> 2.25.1
>>
> .
>