linux-kernel - Re: [PATCH] PCI: epf-mhi: Fix potential NULL dereference in pci_epf_mhi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241105160722.GA448500@rocinante>
Date: Wed, 6 Nov 2024 01:07:22 +0900
From: Krzysztof Wilczyński <kw@...ux.com>
To: Niklas Cassel <cassel@...nel.org>
Cc: Zhongqiu Han <quic_zhonhan@...cinc.com>,
	manivannan.sadhasivam@...aro.org, kishon@...nel.org,
	bhelgaas@...gle.com, lpieralisi@...nel.org, dlemoal@...nel.org,
	mhi@...ts.linux.dev, linux-arm-msm@...r.kernel.org,
	linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] PCI: epf-mhi: Fix potential NULL dereference in
 pci_epf_mhi_bind()

Hello,

[...]
> >  	/* Get MMIO base address from Endpoint controller */
> >  	res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "mmio");
> > +	if (!res) {
> > +		dev_err(&pdev->dev, "Failed to get MMIO base address\n");
> 
> dev_err(&epf->dev, "Failed to get mmio resource\n");
> or
> dev_err(&epf->dev, "Failed to get \"mmio\" resource\n");
> 
> Note: &epf->dev instead of &pdev->dev in order to be consistent with other
> EPF ->bind() functions.
> 
> With that, feel free to add:
> Reviewed-by: Niklas Cassel <cassel@...nel.org>

Thank you Niklas!

No need to send a new version of this patch.  I will update it on the
branch when applying.  Thank you!

	Krzysztof