linux-kernel - Re: [PATCH v3] s390/uvdevice: Support longer secret lists

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <D5EDHMWQTPBJ.1R31D5Y8ROTUT@linux.ibm.com>
Date: Tue, 05 Nov 2024 17:07:18 +0100
From: "Christoph Schlameuss" <schlameuss@...ux.ibm.com>
To: "Steffen Eiden" <seiden@...ux.ibm.com>, <linux-kernel@...r.kernel.org>,
        <linux-s390@...r.kernel.org>
Cc: "Ingo Franzki" <ifranzki@...ux.ibm.com>,
        "Janosch Frank"
 <frankja@...ux.ibm.com>,
        "Claudio Imbrenda" <imbrenda@...ux.ibm.com>,
        <borntraeger@...ux.ibm.com>
Subject: Re: [PATCH v3] s390/uvdevice: Support longer secret lists

LGTM

On Mon Nov 4, 2024 at 4:36 PM CET, Steffen Eiden wrote:
> Enable the list IOCTL to provide lists longer than one page (85 entries).
> The list IOCTL now accepts any argument length in page granularity.
> It fills the argument up to this length with entries until the list
> ends. User space unaware of this enhancement will still receive one page
> of data and an uv_rc 0x0100.
>
> Signed-off-by: Steffen Eiden <seiden@...ux.ibm.com>

Reviewed-by: Christoph Schlameuss <schlameuss@...ux.ibm.com>

> ---
>  v3: remove upper boundary (8 pages) for arg len
>
>  drivers/s390/char/uvdevice.c | 71 ++++++++++++++++++++++++++----------
>  1 file changed, 52 insertions(+), 19 deletions(-)

[...]