linux-kernel - Re: [PATCH v2 4/7] dt-bindings: input: matrix_keypad

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241105-earpiece-swizzle-a3e36d50b9c6@spud>
Date: Tue, 5 Nov 2024 18:22:36 +0000
From: Conor Dooley <conor@...nel.org>
To: Markus Burri <markus.burri@...com>
Cc: linux-kernel@...r.kernel.org,
	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Marek Vasut <marek.vasut@...il.com>, linux-input@...r.kernel.org,
	devicetree@...r.kernel.org
Subject: Re: [PATCH v2 4/7] dt-bindings: input: matrix_keypad - add missing
 property

On Tue, Nov 05, 2024 at 02:03:19PM +0100, Markus Burri wrote:
> Add missing property 'gpio-activelow' to DT schema.

What do you mean "missing property"? Why isn't it sufficient to mark the
GPIOs as GPIO_ACTIVE_LOW in the various -gpios properties?

> 
> Signed-off-by: Markus Burri <markus.burri@...com>
> ---
>  .../devicetree/bindings/input/gpio-matrix-keypad.yaml        | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/input/gpio-matrix-keypad.yaml b/Documentation/devicetree/bindings/input/gpio-matrix-keypad.yaml
> index 745652b..9ea66b3 100644
> --- a/Documentation/devicetree/bindings/input/gpio-matrix-keypad.yaml
> +++ b/Documentation/devicetree/bindings/input/gpio-matrix-keypad.yaml
> @@ -51,6 +51,11 @@ properties:
>        (Legacy property supported: "linux,wakeup")
>      default: false
>  
> +  gpio-activelow:
> +    type: boolean
> +    description: The GPIOs are low active.
> +    default: false

What you want is a flag, not a boolean here btw. Flags you can check for
the presence of, booleans you cannot.

> +
>    debounce-delay-ms:
>      description: Debounce interval in milliseconds.
>      default: 0
> -- 
> 2.39.5
> 

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)