linux-kernel - Re: [PATCH v10 00/27] Enable CET Virtualization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <838cbb8b21fddf14665376360df4b858ec0e6eaf.camel@intel.com>
Date: Tue, 5 Nov 2024 18:25:18 +0000
From: "Edgecombe, Rick P" <rick.p.edgecombe@...el.com>
To: "Yang, Weijiang" <weijiang.yang@...el.com>, "seanjc@...gle.com"
	<seanjc@...gle.com>
CC: "Gao, Chao" <chao.gao@...el.com>, "Hansen, Dave" <dave.hansen@...el.com>,
	"x86@...nel.org" <x86@...nel.org>, "peterz@...radead.org"
	<peterz@...radead.org>, "john.allen@....com" <john.allen@....com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"mlevitsk@...hat.com" <mlevitsk@...hat.com>, "kvm@...r.kernel.org"
	<kvm@...r.kernel.org>, "pbonzini@...hat.com" <pbonzini@...hat.com>
Subject: Re: [PATCH v10 00/27] Enable CET Virtualization

On Mon, 2024-05-06 at 17:31 +0800, Yang, Weijiang wrote:
> > A decent number of comments, but almost all of them are quite minor.  The
> > big
> > open is how to handle save/restore of SSP from userspace.
> > 
> > Instead of spinning a full v10, maybe send an RFC for KVM_{G,S}ET_ONE_REG
> > idea?
> 
> OK, I'll send an RFC patch after relevant discussion is settled.
> 
> > That will make it easier to review, and if you delay v11 a bit, I should be
> > able
> > to get various series applied that have minor conflicts/dependencies, e.g.
> > the
> > MSR access and the kvm_host series.
> I can wait until the series landed in x86-kvm tree.
> Appreciated for your review and comments!

It looks like this series is very close. Since this v10, there was some
discussion on the FPU part that seemed settled:
https://lore.kernel.org/lkml/1c2fd06e-2e97-4724-80ab-8695aa4334e7@intel.com/

Then there was also some discussion on the synthetic MSR solution, which seemed
prescriptive enough:
https://lore.kernel.org/kvm/20240509075423.156858-1-weijiang.yang@intel.com/

Weijiang, had you started a v2 on the synthetic MSR series? Where did you get to
on incorporating the other small v10 feedback?