linux-kernel - Re: [PATCH 0/4] mm: fix checkpatch.pl warnings in memcg v1 code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZylnaFbRZMDYR_Hw@casper.infradead.org>
Date: Tue, 5 Nov 2024 00:31:36 +0000
From: Matthew Wilcox <willy@...radead.org>
To: Keren Sun <kerensun@...gle.com>
Cc: akpm@...ux-foundation.org, roman.gushchin@...ux.dev, hannes@...xchg.org,
	mhocko@...nel.org, shakeel.butt@...ux.dev, muchun.song@...ux.dev,
	cgroups@...r.kernel.org, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/4] mm: fix checkpatch.pl warnings in memcg v1 code

On Mon, Nov 04, 2024 at 02:27:33PM -0800, Keren Sun wrote:
> The patch series fixes 1 error and 27 warnings found by checkpatch.pl in the
> memcg1 code.

Please do not do this.  Fixing checkpatch messages in existing code
is counterproductive.  Only run checkpatch on new code, and even then
take its suggestions with a grain of salt.