linux-kernel - Re: [PATCH 0/4] mm: fix checkpatch.pl warnings in memcg v1 code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZylqcBXieSti46xr@google.com>
Date: Tue, 5 Nov 2024 00:44:32 +0000
From: Roman Gushchin <roman.gushchin@...ux.dev>
To: Matthew Wilcox <willy@...radead.org>
Cc: Keren Sun <kerensun@...gle.com>, akpm@...ux-foundation.org,
	hannes@...xchg.org, mhocko@...nel.org, shakeel.butt@...ux.dev,
	muchun.song@...ux.dev, cgroups@...r.kernel.org, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/4] mm: fix checkpatch.pl warnings in memcg v1 code

On Tue, Nov 05, 2024 at 12:31:36AM +0000, Matthew Wilcox wrote:
> On Mon, Nov 04, 2024 at 02:27:33PM -0800, Keren Sun wrote:
> > The patch series fixes 1 error and 27 warnings found by checkpatch.pl in the
> > memcg1 code.
> 
> Please do not do this.  Fixing checkpatch messages in existing code
> is counterproductive.  Only run checkpatch on new code, and even then
> take its suggestions with a grain of salt.

I do agree in general, but not in this case. These are nice cleanups
no matter what checkpatch.pl thinks of it :)

Thanks!