linux-kernel - Re: [PATCH 1/2] x86: cpu/bugs: add support for AMD ERAPS feature

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e5463e70-a0a6-4cce-9c2c-4a09c2e622ef@citrix.com>
Date: Tue, 5 Nov 2024 00:04:28 +0000
From: Andrew Cooper <andrew.cooper3@...rix.com>
To: dave.hansen@...el.com
Cc: Amit.Shah@....com, Babu.Moger@....com, David.Kaplan@....com,
 Sandipan.Das@....com, Thomas.Lendacky@....com, boris.ostrovsky@...cle.com,
 bp@...en8.de, corbet@....net, daniel.sneddon@...ux.intel.com,
 dave.hansen@...ux.intel.com, hpa@...or.com, jpoimboe@...nel.org,
 kai.huang@...el.com, kvm@...r.kernel.org, linux-doc@...r.kernel.org,
 linux-kernel@...r.kernel.org, mingo@...hat.com,
 pawan.kumar.gupta@...ux.intel.com, pbonzini@...hat.com,
 peterz@...radead.org, seanjc@...gle.com, tglx@...utronix.de, x86@...nel.org
Subject: Re: [PATCH 1/2] x86: cpu/bugs: add support for AMD ERAPS feature

> So, I'll flip this back around.  Today, X86_FEATURE_RSB_CTXSW zaps the
> RSB whenever RSP is updated to a new task stack.  Please convince me
> that ERAPS provides superior coverage or is unnecessary in all the
> possible combinations switching between:
>
> 	different thread, same mm
> 	user=>kernel, same mm
> 	kernel=>user, same mm
> 	different mm (we already covered this)
>
> Because several of those switches can happen without a CR3 write or INVPCID.

user=>kernel=>user, same mm explicitly does not want to flush the RAS,
because if the system call is shallow enough, some of the userspace RAS
is still intact on when you get back into user mode.

The case which I expect will go wrong is user=>kernel=>different kthread
because this stays on the same mm.

That does need to flush the RAS and won't hit any TLB maintenance
instructions that I'm aware of.

~Andrew