linux-kernel - Re: [PATCH 1/2] dt-bindings: hwmon: (pmbus/adp1050): Support adp1051 and adp1055: add bindings.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241106-linoleum-kebab-decf14f54f76@spud>
Date: Wed, 6 Nov 2024 15:48:55 +0000
From: Conor Dooley <conor@...nel.org>
To: Alexis Cezar Torreno <alexisczezar.torreno@...log.com>
Cc: linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
	devicetree@...r.kernel.org, linux-hwmon@...r.kernel.org,
	Radu Sabau <radu.sabau@...log.com>,
	Jean Delvare <jdelvare@...e.com>,
	Guenter Roeck <linux@...ck-us.net>, Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Jonathan Corbet <corbet@....net>,
	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
	Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
Subject: Re: [PATCH 1/2] dt-bindings: hwmon: (pmbus/adp1050): Support adp1051
 and adp1055: add bindings.

On Wed, Nov 06, 2024 at 05:03:10PM +0800, Alexis Cezar Torreno wrote:
> Add dt-bindings for adp1051 and adp1055 pmbus.
> ADP1051: 6 PWM for I/O Voltage, I/O Current, Temperature
> ADP1055: 6 PWM for I/O Voltage, I/O Current, Power, Temperature
> 
> Signed-off-by: Alexis Cezar Torreno <alexisczezar.torreno@...log.com>
> ---
>  .../devicetree/bindings/hwmon/pmbus/adi,adp1050.yaml | 12 ++++++++++--
>  1 file changed, 10 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/hwmon/pmbus/adi,adp1050.yaml b/Documentation/devicetree/bindings/hwmon/pmbus/adi,adp1050.yaml
> index 10c2204bc3df..88aaa29b3bd1 100644
> --- a/Documentation/devicetree/bindings/hwmon/pmbus/adi,adp1050.yaml
> +++ b/Documentation/devicetree/bindings/hwmon/pmbus/adi,adp1050.yaml
> @@ -10,16 +10,24 @@ maintainers:
>    - Radu Sabau <radu.sabau@...log.com>
>  
>  description: |
> -   The ADP1050 is used to monitor system voltages, currents and temperatures.
> +   The ADP1050 and similar devices are used to monitor system voltages,
> +   currents, power, and temperatures.
> +
>     Through the PMBus interface, the ADP1050 targets isolated power supplies
>     and has four individual monitors for input/output voltage, input current
>     and temperature.
>     Datasheet:
>       https://www.analog.com/en/products/adp1050.html
> +     https://www.analog.com/en/products/adp1051.html
> +     https://www.analog.com/en/products/adp1055.html
>  
>  properties:
> +

That's an abnormal newline, leave it alone if you respin.

Acked-by: Conor Dooley <conor.dooley@...rochip.com>

Cheers,
Conor.

>    compatible:
> -    const: adi,adp1050
> +    enum:
> +      - adi,adp1050
> +      - adi,adp1051
> +      - adi,adp1055
>  
>    reg:
>      maxItems: 1
> -- 
> 2.34.1
> 

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)