[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CAMfZQbx6-11k1eN1FC=_kRSgsh7FbTp2uvk3ufh+gOyhvxgEGw@mail.gmail.com>
Date: Wed, 6 Nov 2024 07:48:54 -0800
From: Fritz Koenig <frkoenig@...omium.org>
To: Fritz Koenig <frkoenig@...omium.org>
Cc: Stanimir Varbanov <stanimir.k.varbanov@...il.com>,
Vikash Garodia <quic_vgarodia@...cinc.com>, "Bryan O'Donoghue" <bryan.odonoghue@...aro.org>,
Mauro Carvalho Chehab <mchehab@...nel.org>, Dikshita Agarwal <quic_dikshita@...cinc.com>,
Nathan Hebert <nhebert@...omium.org>, linux-media@...r.kernel.org,
linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 0/2] media: venus: Add hierarchical h.264 controls
Stanimir,
Would it be possible to get this in the 6.13 pull request?
Thanks.
On Tue, Oct 22, 2024 at 10:40 AM Fritz Koenig <frkoenig@...omium.org> wrote:
>
> v5:
> - fixed formatting
> - included reviwed by for patch 2
> - Link to v4: https://lore.kernel.org/r/20241017-submit-v4-0-d852bc7f7fdc@chromium.org
>
> v4:
> - addressed feedback from Dikshita
> - included reviewed by for patch 1
> - Link to v3: https://lore.kernel.org/r/20240814-submit-v3-0-f7d05e3e8560@chromium.org
>
> v3:
> - dropped reordering patch
> - updated cover letter
>
> v2:
> - cover letter
> - testing methodology
> - Signed-off-by
>
> V4L2 has support for encoding with hierarchical frames using the
> V4L2_CID_MPEG_VIDEO_H264_HIERARCHICAL_CODING* controls. This allows for
> specifing frame references needed for temporal scalability. Encoding a
> single stream with a single layer allows for the layer to be dropped and
> the stream to be decoded without artifacts.
>
> ChromeOS is planning to use this feature for the L1T2 web standard[1].
> This allows video conferencing apps to encode once for a clients with
> different performance/bandwidth capabilities. As the application is a
> real time encoder only P frame support is added.
>
> The ChromeOS test framework ("tast") was used to verify that no
> regressions are present. This was done on SC7180 ("trogdor"). These
> patches were also run on SC7280, but not with as an extensive test set.
>
> Verification of the added controls was done with a bitstream analyser to
> make sure that reference frame management is correct.
>
> [1]: https://www.w3.org/TR/webrtc-svc/#L1T2*
>
> Signed-off-by: Fritz Koenig <frkoenig@...omium.org>
> ---
> Fritz Koenig (2):
> media: venus: Helper function for dynamically updating bitrate
> media: venus: Enable h.264 hierarchical coding
>
> drivers/media/platform/qcom/venus/core.h | 4 +
> drivers/media/platform/qcom/venus/venc.c | 71 +++++++++-----
> drivers/media/platform/qcom/venus/venc_ctrls.c | 126 ++++++++++++++++++++++---
> 3 files changed, 164 insertions(+), 37 deletions(-)
> ---
> base-commit: d07b43284ab356daf7ec5ae1858a16c1c7b6adab
> change-id: 20240814-submit-05880a074377
>
> Best regards,
> --
> Fritz Koenig <frkoenig@...omium.org>
>
Powered by blists - more mailing lists