linux-kernel - Re: [PATCH 1/7] dt-bindings: clock: qcom-rpmhcc: Add RPMHCC bindings for SM8750

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6486448c-15b3-4c46-8104-e5c8c1b5ec2e@quicinc.com>
Date: Wed, 6 Nov 2024 23:44:41 +0530
From: Taniya Das <quic_tdas@...cinc.com>
To: Krzysztof Kozlowski <krzk@...nel.org>,
        Melody Olvera
	<quic_molvera@...cinc.com>
CC: Bjorn Andersson <andersson@...nel.org>,
        Michael Turquette
	<mturquette@...libre.com>,
        Stephen Boyd <sboyd@...nel.org>, Rob Herring
	<robh@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Conor Dooley
	<conor+dt@...nel.org>,
        Trilok Soni <quic_tsoni@...cinc.com>,
        "Satya Durga
 Srinivasu Prabhala --cc=linux-arm-msm @ vger . kernel . org"
	<quic_satyap@...cinc.com>,
        <linux-clk@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/7] dt-bindings: clock: qcom-rpmhcc: Add RPMHCC bindings
 for SM8750



On 10/22/2024 11:46 AM, Krzysztof Kozlowski wrote:
> On Mon, Oct 21, 2024 at 04:03:53PM -0700, Melody Olvera wrote:
>> From: Taniya Das <quic_tdas@...cinc.com>
>>
>> Add bindings and update documentation for clock rpmh driver on SM8750
>> SoCs.
>>
>> Signed-off-by: Taniya Das <quic_tdas@...cinc.com>
>> Signed-off-by: Melody Olvera <quic_molvera@...cinc.com>
>> ---
> 
> A nit, subject: drop second/last, redundant "bindings for". The
> "dt-bindings" prefix is already stating that these are bindings.
> See also:
> https://elixir.bootlin.com/linux/v6.7-rc8/source/Documentation/devicetree/bindings/submitting-patches.rst#L18
> 
> This applies to all your patches.
> 

I will remove the extra "bindings" in the next patch and also cleanup 
where ever required.

> There is already CXO clock, so why pad is needed? All of these clocks
> come via some pad, right? Commit msg could explain here this. Otherwise
> it just duplicates the diff.
> 

Yes, I will fix the CXO clock and remove the newly added pad clock in 
the next patch.

> Best regards,
> Krzysztof
> 

-- 
Thanks & Regards,
Taniya Das.