linux-kernel - Re: [PATCH overlayfs-next v3 1/4] cred: Add a light version of override/revert

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <202411070234.EOrhSGRU-lkp@intel.com>
Date: Thu, 7 Nov 2024 02:56:30 +0800
From: kernel test robot <lkp@...el.com>
To: Vinicius Costa Gomes <vinicius.gomes@...el.com>, brauner@...nel.org,
	amir73il@...il.com, hu1.chen@...el.com
Cc: oe-kbuild-all@...ts.linux.dev, miklos@...redi.hu,
	malini.bhandaru@...el.com, tim.c.chen@...el.com,
	mikko.ylinen@...el.com, linux-unionfs@...r.kernel.org,
	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
	Vinicius Costa Gomes <vinicius.gomes@...el.com>
Subject: Re: [PATCH overlayfs-next v3 1/4] cred: Add a light version of
 override/revert_creds()

Hi Vinicius,

kernel test robot noticed the following build warnings:

[auto build test WARNING on next-20241105]
[also build test WARNING on v6.12-rc6]
[cannot apply to brauner-vfs/vfs.all linus/master v6.12-rc6 v6.12-rc5 v6.12-rc4]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Vinicius-Costa-Gomes/cred-Add-a-light-version-of-override-revert_creds/20241106-033748
base:   next-20241105
patch link:    https://lore.kernel.org/r/20241105193514.828616-2-vinicius.gomes%40intel.com
patch subject: [PATCH overlayfs-next v3 1/4] cred: Add a light version of override/revert_creds()
config: x86_64-randconfig-121-20241106 (https://download.01.org/0day-ci/archive/20241107/202411070234.EOrhSGRU-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241107/202411070234.EOrhSGRU-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202411070234.EOrhSGRU-lkp@intel.com/

sparse warnings: (new ones prefixed by >>)
   kernel/cred.c:104:9: sparse: sparse: incompatible types in comparison expression (different address spaces):
   kernel/cred.c:104:9: sparse:    struct cred *
   kernel/cred.c:104:9: sparse:    struct cred const [noderef] __rcu *
   kernel/cred.c:105:9: sparse: sparse: incompatible types in comparison expression (different address spaces):
   kernel/cred.c:105:9: sparse:    struct cred *
   kernel/cred.c:105:9: sparse:    struct cred const [noderef] __rcu *
   kernel/cred.c:121:9: sparse: sparse: incorrect type in argument 1 (different address spaces) @@     expected struct atomic64_t const [usertype] *v @@     got struct atomic64_t const [noderef] __rcu * @@
   kernel/cred.c:121:9: sparse:     expected struct atomic64_t const [usertype] *v
   kernel/cred.c:121:9: sparse:     got struct atomic64_t const [noderef] __rcu *
   kernel/cred.c:124:22: sparse: sparse: cast removes address space '__rcu' of expression
   kernel/cred.c:127:17: sparse: sparse: cast removes address space '__rcu' of expression
   kernel/cred.c:218:13: sparse: sparse: incorrect type in assignment (different address spaces) @@     expected struct cred const *old @@     got struct cred const [noderef] __rcu *cred @@
   kernel/cred.c:218:13: sparse:     expected struct cred const *old
   kernel/cred.c:218:13: sparse:     got struct cred const [noderef] __rcu *cred
   kernel/cred.c:305:47: sparse: sparse: incorrect type in argument 1 (different address spaces) @@     expected struct cred const *cred @@     got struct cred const [noderef] __rcu *cred @@
   kernel/cred.c:305:47: sparse:     expected struct cred const *cred
   kernel/cred.c:305:47: sparse:     got struct cred const [noderef] __rcu *cred
   kernel/cred.c:305:30: sparse: sparse: incorrect type in assignment (different address spaces) @@     expected struct cred const [noderef] __rcu *real_cred @@     got struct cred const * @@
   kernel/cred.c:305:30: sparse:     expected struct cred const [noderef] __rcu *real_cred
   kernel/cred.c:305:30: sparse:     got struct cred const *
   kernel/cred.c:306:17: sparse: sparse: incorrect type in argument 1 (different address spaces) @@     expected struct atomic64_t const [usertype] *v @@     got struct atomic64_t const [noderef] __rcu * @@
   kernel/cred.c:306:17: sparse:     expected struct atomic64_t const [usertype] *v
   kernel/cred.c:306:17: sparse:     got struct atomic64_t const [noderef] __rcu *
   kernel/cred.c:344:32: sparse: sparse: incorrect type in assignment (different address spaces) @@     expected struct cred const [noderef] __rcu *real_cred @@     got struct cred const * @@
   kernel/cred.c:344:32: sparse:     expected struct cred const [noderef] __rcu *real_cred
   kernel/cred.c:344:32: sparse:     got struct cred const *
   kernel/cred.c:395:38: sparse: sparse: incorrect type in initializer (different address spaces) @@     expected struct cred const *old @@     got struct cred const [noderef] __rcu *real_cred @@
   kernel/cred.c:395:38: sparse:     expected struct cred const *old
   kernel/cred.c:395:38: sparse:     got struct cred const [noderef] __rcu *real_cred
   kernel/cred.c:400:9: sparse: sparse: incompatible types in comparison expression (different address spaces):
   kernel/cred.c:400:9: sparse:    struct cred const [noderef] __rcu *
   kernel/cred.c:400:9: sparse:    struct cred const *
   kernel/cred.c:519:46: sparse: sparse: incorrect type in initializer (different address spaces) @@     expected struct cred const *override @@     got struct cred const [noderef] __rcu *cred @@
   kernel/cred.c:519:46: sparse:     expected struct cred const *override
   kernel/cred.c:519:46: sparse:     got struct cred const [noderef] __rcu *cred
   kernel/cred.c:301:19: sparse: sparse: dereference of noderef expression
   kernel/cred.c: note: in included file:
>> include/linux/cred.h:182:41: sparse: sparse: incorrect type in initializer (different address spaces) @@     expected struct cred const *old @@     got struct cred const [noderef] __rcu *cred @@
   include/linux/cred.h:182:41: sparse:     expected struct cred const *old
   include/linux/cred.h:182:41: sparse:     got struct cred const [noderef] __rcu *cred

vim +182 include/linux/cred.h

   174	
   175	/*
   176	 * Override creds without bumping reference count. Caller must ensure
   177	 * reference remains valid or has taken reference. Almost always not the
   178	 * interface you want. Use override_creds()/revert_creds() instead.
   179	 */
   180	static inline const struct cred *override_creds_light(const struct cred *override_cred)
   181	{
 > 182		const struct cred *old = current->cred;
   183	
   184		rcu_assign_pointer(current->cred, override_cred);
   185		return old;
   186	}
   187	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki