linux-kernel - Re: [RFC PATCH] x86/sev: Cleanup vc_handle

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241106194701.GKZyvHtQrLXvZOJhbP@fat_crate.local>
Date: Wed, 6 Nov 2024 20:47:01 +0100
From: Borislav Petkov <bp@...en8.de>
To: Tom Lendacky <thomas.lendacky@....com>
Cc: x86-ml <x86@...nel.org>, lkml <linux-kernel@...r.kernel.org>,
	linux-coco@...ts.linux.dev
Subject: Re: [RFC PATCH] x86/sev: Cleanup vc_handle_msr()

On Wed, Nov 06, 2024 at 01:40:47PM -0600, Tom Lendacky wrote:
> Is the !! necessary? It should have either 0 or 1 because of the boolean
> operation used to set it, right?

I was going to be overly cautious but integer promotion will make sure there
really is a 0 or a 1. So yeah, I can drop the !!.

> 
> >  
> > -	if ((ret == ES_OK) && (!exit_info_1)) {
> > +	if ((ret == ES_OK) && (!write)) {
> 
> I guess the parentheses around "!write" can be removed while your at it.

Ack.

> Other than those two little things...
> 
> Reviewed-by: Tom Lendacky <thomas.lendacky@....com>

Thanks!

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette