linux-kernel - Re: [PATCH v2 1/2] arm64: dts: qcom: qcs615: add SDHC1 and SDHC2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <FF5BD9CD-8E5E-4C40-906C-8552C067AE8C@linaro.org>
Date: Wed, 06 Nov 2024 09:10:57 +0000
From: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
To: Yuanjie Yang <quic_yuanjiey@...cinc.com>, ulf.hansson@...aro.org,
 robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org,
 bhupesh.sharma@...aro.org, andersson@...nel.org, konradybcio@...nel.org
CC: linux-mmc@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org,
 quic_tingweiz@...cinc.com, quic_yuanjiey@...cinc.com
Subject: Re: [PATCH v2 1/2] arm64: dts: qcom: qcs615: add SDHC1 and SDHC2

On 6 November 2024 07:56:57 GMT, Yuanjie Yang <quic_yuanjiey@...cinc.com> wrote:
>On Wed, Nov 06, 2024 at 09:36:56AM +0200, Dmitry Baryshkov wrote:
>> On Wed, Nov 06, 2024 at 03:23:42PM +0800, Yuanjie Yang wrote:
>> > Add SDHC1 and SDHC2 support to the QCS615 Ride platform. The SDHC1
>> > and SDHC2 of QCS615 are derived from SM6115. Include the relevant
>> > binding documents accordingly.
>> 
>> Which binding documents?
>Thanks, the binding documents is sdhci-msm.yaml.
>I have modified this yaml patch in patch v1, and this yaml patch is
>applied, so I remove this yaml patch in patch v2.
>link:https://lore.kernel.org/all/CAPDyKFr-Gzd3Mzn+vN6DXO9C4Xrvpv4z5V2G_VRTzOa=89Fd3w@mail.gmail.com/

The question is why do you mention bindings in the DTSI commit message? Please don't just C&P your texts.

>
>> > Additionally, configure SDHC1-related
>> > and SDHC2-related opp, power, and interconnect settings in the device
>> > tree.
>> > 
>> > Signed-off-by: Yuanjie Yang <quic_yuanjiey@...cinc.com>
>> > ---
>> >  arch/arm64/boot/dts/qcom/qcs615.dtsi | 198 +++++++++++++++++++++++++++
>> >  1 file changed, 198 insertions(+)
>> > 
>> 
>> -- 
>> With best wishes
>> Dmitry
>
>Thanks,
>Yuanjie