linux-kernel - Re: [PATCH RESEND net-next v4 6/9] net: ip: make ip_route_input

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CADxym3adJA1rEHc1GVCmA0_CvuBvMyEF8GOJjm_69uvXhgu9GQ@mail.gmail.com>
Date: Wed, 6 Nov 2024 17:40:16 +0800
From: Menglong Dong <menglong8.dong@...il.com>
To: Paolo Abeni <pabeni@...hat.com>
Cc: davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org, 
	horms@...nel.org, dsahern@...nel.org, pablo@...filter.org, 
	kadlec@...filter.org, roopa@...dia.com, razor@...ckwall.org, 
	gnault@...hat.com, bigeasy@...utronix.de, hawk@...nel.org, idosch@...dia.com, 
	dongml2@...natelecom.cn, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, 
	netfilter-devel@...r.kernel.org, coreteam@...filter.org, 
	bridge@...ts.linux.dev, bpf@...r.kernel.org
Subject: Re: [PATCH RESEND net-next v4 6/9] net: ip: make ip_route_input_noref()
 return drop reasons

On Tue, Nov 5, 2024 at 7:22 PM Paolo Abeni <pabeni@...hat.com> wrote:
>
> Hi,
>
> On 10/30/24 02:41, Menglong Dong wrote:
> > @@ -175,10 +175,12 @@ static void ip_expire(struct timer_list *t)
> >
> >       /* skb has no dst, perform route lookup again */
> >       iph = ip_hdr(head);
> > -     err = ip_route_input_noref(head, iph->daddr, iph->saddr, ip4h_dscp(iph),
> > -                                head->dev);
> > -     if (err)
> > +     reason = ip_route_input_noref(head, iph->daddr, iph->saddr,
> > +                                   ip4h_dscp(iph), head->dev);
> > +     if (reason)
> >               goto out;
> > +     else
> > +             reason = SKB_DROP_REASON_FRAG_REASM_TIMEOUT;
>
> I think the else branch above is confusing - and unneeded.

Yeah, that makes sense.

> Please move the assignment after the comment below, so it's clear why we
> get a TIMEOUT drop reason.

Okay!

Thanks!
Menglong Dong

>
> Thanks,
>
> Paolo
>