linux-kernel - Re: [PATCH RESEND net-next v4 8/9] net: ip: make ip_mkroute_input/__mkroute

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CADxym3Z6GdXdFoXcex-h300xxAbCPtbVoxPMRNx9sKaWh7_MHw@mail.gmail.com>
Date: Wed, 6 Nov 2024 19:58:28 +0800
From: Menglong Dong <menglong8.dong@...il.com>
To: Paolo Abeni <pabeni@...hat.com>
Cc: davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org, 
	horms@...nel.org, dsahern@...nel.org, pablo@...filter.org, 
	kadlec@...filter.org, roopa@...dia.com, razor@...ckwall.org, 
	gnault@...hat.com, bigeasy@...utronix.de, hawk@...nel.org, idosch@...dia.com, 
	dongml2@...natelecom.cn, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, 
	netfilter-devel@...r.kernel.org, coreteam@...filter.org, 
	bridge@...ts.linux.dev, bpf@...r.kernel.org
Subject: Re: [PATCH RESEND net-next v4 8/9] net: ip: make ip_mkroute_input/__mkroute_input
 return drop reasons

On Tue, Nov 5, 2024 at 7:25 PM Paolo Abeni <pabeni@...hat.com> wrote:
>
> On 10/30/24 02:41, Menglong Dong wrote:
> > @@ -1820,7 +1822,8 @@ static int __mkroute_input(struct sk_buff *skb, const struct fib_result *res,
> >                */
> >               if (out_dev == in_dev &&
> >                   IN_DEV_PROXY_ARP_PVLAN(in_dev) == 0) {
> > -                     err = -EINVAL;
> > +                     /* what do we name this situation? */
> > +                     reason = SKB_DROP_REASON_ARP_PVLAN_DISABLE;
>
> I don't have a better suggestion :(
>
> Please drop the comment and re-iterate the question in the commit
> message after a '---' separator, so we can merge the patch unmodified if
> nobody suggests a better one.

Okay, I'll move this comment into the commit log, which
I usually place the change logs in.

Thanks!
Menglong Dong

>
> Thanks,
>
> Paolo
>