linux-kernel - Re: [PATCH] fs: aio: Transition from Linked List to Hash Table for Active Request Management in AIO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241106105700.10735-1-pvmohammedanees2003@gmail.com>
Date: Wed,  6 Nov 2024 16:27:00 +0530
From: Mohammed Anees <pvmohammedanees2003@...il.com>
To: jack@...e.cz
Cc: bcrl@...ck.org,
	brauner@...nel.org,
	linux-aio@...ck.org,
	linux-fsdevel@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	pvmohammedanees2003@...il.com,
	viro@...iv.linux.org.uk,
	willy@...radead.org
Subject: Re: [PATCH] fs: aio: Transition from Linked List to Hash Table for Active Request Management in AIO

> Well, I'd say that calling io_cancel() isn't really frequent operation. Or
> are you aware of any workload that would be regularly doing that? Hence
> optimizing performance for such operation isn't going to bring much benefit
> to real users. On the other hand the additional complexity of handling
> hashtable for requests in flight (although it isn't big on its own) is
> going to impact everybody using AIO. Hence I agree with Matthew that
> changes like you propose are not a clear win when looking at the bigger
> picture and need good justification.

Makes sense to me, the added complexity may not be worth the 
marginal performance gain. Thanks for helping me with this!