[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <ZyrFfzLEFDjOTAHB@slm.duckdns.org>
Date: Tue, 5 Nov 2024 15:25:19 -1000
From: Tejun Heo <tj@...nel.org>
To: Andrea Righi <arighi@...dia.com>
Cc: David Vernet <void@...ifault.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH sched_ext/for-6.13] sched_ext: Do not enable LLC/NUMA
optimizations when domains overlap
On Tue, Nov 05, 2024 at 03:15:59PM -1000, Tejun Heo wrote:
> Hello, Andrea.
>
> On Wed, Nov 06, 2024 at 02:08:00AM +0100, Andrea Righi wrote:
> ...
> > I think this is only possible in a virtualized environment, in this case
> > LLC should be disabled and NUMA enabled. Maybe it's worth checking also
> > for the case where LLC > NUMA...
>
> I think the current code is okay. It just needs a short comment explaining
> why it's so. A cleaner alternative may be walking the llc sd's and verify
> whether any two llcs share the same node sd as an ancestor.
Or maybe just compare the total number of LLC sd's and NUMA sd's.
Thanks.
--
tejun
Powered by blists - more mailing lists