linux-kernel - Re: [PATCH v3 1/2] drm/virtio: Use drm_gem_plane_helper_prepare

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAF6AEGv73+k4fNm-5ZXTyf5jizx=Yq=HeA5AC7K-DrDA1Edn2w@mail.gmail.com>
Date: Tue, 5 Nov 2024 17:27:09 -0800
From: Rob Clark <robdclark@...il.com>
To: Dmitry Osipenko <dmitry.osipenko@...labora.com>
Cc: David Airlie <airlied@...hat.com>, Gerd Hoffmann <kraxel@...hat.com>, 
	Gurchetan Singh <gurchetansingh@...omium.org>, Chia-I Wu <olvaffe@...il.com>, 
	Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@....com>, Kim Dongwon <dongwon.kim@...el.com>, 
	Kasireddy Vivek <vivek.kasireddy@...el.com>, dri-devel@...ts.freedesktop.org, 
	virtualization@...ts.linux-foundation.org, linux-kernel@...r.kernel.org, 
	kernel@...labora.com
Subject: Re: [PATCH v3 1/2] drm/virtio: Use drm_gem_plane_helper_prepare_fb()

On Sun, Oct 20, 2024 at 4:08 PM Dmitry Osipenko
<dmitry.osipenko@...labora.com> wrote:
>
> From: Dongwon Kim <dongwon.kim@...el.com>
>
> Use drm_gem_plane_helper_prepare_fb() helper for explicit framebuffer
> synchronization. We need to wait for explicit fences in a case of
> Venus and native contexts when guest user space uses explicit fencing.
>
> Signed-off-by: Dongwon Kim <dongwon.kim@...el.com>
> [dmitry.osipenko@...labora.com>: Edit commit message]
> Signed-off-by: Dmitry Osipenko <dmitry.osipenko@...labora.com>

Reviewed-by: Rob Clark <robdclark@...il.com>

> ---
>  drivers/gpu/drm/virtio/virtgpu_plane.c | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/drivers/gpu/drm/virtio/virtgpu_plane.c b/drivers/gpu/drm/virtio/virtgpu_plane.c
> index a72a2dbda031..ab7232921cb7 100644
> --- a/drivers/gpu/drm/virtio/virtgpu_plane.c
> +++ b/drivers/gpu/drm/virtio/virtgpu_plane.c
> @@ -26,6 +26,7 @@
>  #include <drm/drm_atomic_helper.h>
>  #include <drm/drm_damage_helper.h>
>  #include <drm/drm_fourcc.h>
> +#include <drm/drm_gem_atomic_helper.h>
>
>  #include "virtgpu_drv.h"
>
> @@ -254,6 +255,9 @@ static int virtio_gpu_plane_prepare_fb(struct drm_plane *plane,
>
>         vgfb = to_virtio_gpu_framebuffer(new_state->fb);
>         bo = gem_to_virtio_gpu_obj(vgfb->base.obj[0]);
> +
> +       drm_gem_plane_helper_prepare_fb(plane, new_state);
> +
>         if (!bo || (plane->type == DRM_PLANE_TYPE_PRIMARY && !bo->guest_blob))
>                 return 0;
>
> --
> 2.47.0
>