linux-kernel - Re: [PATCH v2 1/1] x86/fred: Clear WFE in missing-ENDBRANCH #CPs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6734b32e-c089-4754-9209-4ba01095c785@intel.com>
Date: Thu, 7 Nov 2024 10:57:57 -0800
From: Dave Hansen <dave.hansen@...el.com>
To: Xin Li <xin@...or.com>, linux-kernel@...r.kernel.org
Cc: tglx@...utronix.de, mingo@...hat.com, bp@...en8.de,
 dave.hansen@...ux.intel.com, x86@...nel.org, hpa@...or.com,
 peterz@...radead.org, andrew.cooper3@...rix.com
Subject: Re: [PATCH v2 1/1] x86/fred: Clear WFE in missing-ENDBRANCH #CPs

On 11/7/24 10:54, Xin Li wrote:
> +static void ibt_clear_fred_wfe(struct pt_regs *regs)
> +{
> +    regs->fred_cs.wfe = 0;
> +}

Also, just looking at this, we have obviously FRED-specific code without
any FRED checks.  Now I know we asked you to remove those checks, but
this does need commenting or at least a changelog sentence on why this
incorrect-looking code is still OK.