[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CAN+CAwOWCxOTaTzAgotHAQPvp4VBgaAVwwXUPfhmmsXCCR_2Hw@mail.gmail.com>
Date: Thu, 7 Nov 2024 14:28:27 -0500
From: Joshua Hahn <joshua.hahnjy@...il.com>
To: Shakeel Butt <shakeel.butt@...ux.dev>
Cc: hannes@...xchg.org, mhocko@...nel.org, roman.gushchin@...ux.dev,
muchun.song@...ux.dev, akpm@...ux-foundation.org, cgroups@...r.kernel.org,
linux-mm@...ck.org, linux-kernel@...r.kernel.org, kernel-team@...a.com
Subject: Re: [PATCH 2/2] memcg/hugetlb: Deprecate hugetlb memcg
try-commit-cancel charging
On Thu, Nov 7, 2024 at 1:58 PM Shakeel Butt <shakeel.butt@...ux.dev> wrote:
>
> On Thu, Nov 07, 2024 at 01:27:53PM -0500, Joshua Hahn wrote:
> > On Wed, Nov 6, 2024 at 6:50 PM Shakeel Butt <shakeel.butt@...ux.dev> wrote:
> > >
> > > Please cleanup mem_cgroup_cancel_charge() and mem_cgroup_commit_charge()
> > > as well as there will be no users after this patch.
> > >
> >
> > Hi Shakeel,
> >
> > Thank you for your feedback. Unfortunately, it seems like even after this
> > patch removes the references from hugetlb.c, there are still some
> > references from other files.
> >
> > mem_cgroup_cancel_charge:
> > - memcontrol-v1.c~__mem_cgroup_clear_mc(void)
>
> __mem_cgroup_clear_mc() is gone. No more reference to
> mem_cgroup_cancel_charge after your patch.
Ah I see, sorry for the confusion. I was looking at 6.12-rc6,
but I see now your "fully deprecate charge moving" patch.
I'll remove it completely in that case.
Thank you for your help!
Joshua
Powered by blists - more mailing lists