linux-kernel - [PATCH] intel-hid: fix volume buttons on Thinkpad X12 Detachable Tablet Gen 1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241107205908.69279-1-cole@stowell.pro>
Date: Thu, 07 Nov 2024 20:59:34 +0000
From: Cole Stowell <cole@...well.pro>
To: platform-driver-x86@...r.kernel.org
Cc: linux-kernel@...r.kernel.org, ilpo.jarvinen@...ux.intel.com, hdegoede@...hat.com, alexhung@...il.com, Cole Stowell <cole@...well.pro>, Mary Strodl <mstrodl@....rit.edu>
Subject: [PATCH] intel-hid: fix volume buttons on Thinkpad X12 Detachable Tablet Gen 1

Volume buttons on Lenovo Thinkpad X12 Detachable Tablet Gen 1 did not
send any input events when pressed. When loading intel-hid with the 5
Button Array explicitly enabled, the buttons functioned normally.

Adds the X12 Detachable Tablet Gen 1 to the `button_array_table`.

However, the driver is unable to call INTEL_HID_DSM_BTNE_FN and prints
the warning "failed to set button capability" when attempting to enable
or disable the 5 Button Array. I'm not sure if this is normal,
but the warning seems harmless.

Co-developed-by: Mary Strodl <mstrodl@....rit.edu>
Signed-off-by: Mary Strodl <mstrodl@....rit.edu>
Signed-off-by: Cole Stowell <cole@...well.pro>
---
 drivers/platform/x86/intel/hid.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/drivers/platform/x86/intel/hid.c b/drivers/platform/x86/intel/hid.c
index 445e7a59beb4..48ad75a56199 100644
--- a/drivers/platform/x86/intel/hid.c
+++ b/drivers/platform/x86/intel/hid.c
@@ -118,6 +118,13 @@ static const s
truct dmi_system_id button_array_table[] = {
 			DMI_MATCH(DMI_PRODUCT_NAME, "HP Spectre x2 Detachable"),
 		},
 	},
+	{
+		.ident = "Lenovo ThinkPad X1 Tablet Gen 1",
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
+			DMI_MATCH(DMI_PRODUCT_FAMILY, "ThinkPad X12 Detachable Gen 1"),
+		},
+	},
 	{
 		.ident = "Lenovo ThinkPad X1 Tablet Gen 2",
 		.matches = {
-- 
2.47.0


Download attachment "publickey - cole@...well.pro -
 0x146D8A8D.asc" of type "application/pgp-keys" (697 bytes)

Download attachment "signature.asc" of type "application/pgp-signature" (250 bytes)