linux-kernel - Re: [PATCH] intel-hid: fix volume buttons on Thinkpad X12 Detachable Tablet Gen 1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <32b477e7-27b7-4468-b506-2c565b2010e1@redhat.com>
Date: Thu, 7 Nov 2024 22:55:30 +0100
From: Hans de Goede <hdegoede@...hat.com>
To: Cole Stowell <cole@...well.pro>, platform-driver-x86@...r.kernel.org
Cc: linux-kernel@...r.kernel.org, ilpo.jarvinen@...ux.intel.com,
 alexhung@...il.com, Mary Strodl <mstrodl@....rit.edu>
Subject: Re: [PATCH] intel-hid: fix volume buttons on Thinkpad X12 Detachable
 Tablet Gen 1

Hi,

Thank you for the patch.

On 7-Nov-24 9:59 PM, Cole Stowell wrote:
> Volume buttons on Lenovo Thinkpad X12 Detachable Tablet Gen 1 did not
> send any input events when pressed. When loading intel-hid with the 5
> Button Array explicitly enabled, the buttons functioned normally.
> 
> Adds the X12 Detachable Tablet Gen 1 to the `button_array_table`.
> 
> However, the driver is unable to call INTEL_HID_DSM_BTNE_FN and prints
> the warning "failed to set button capability" when attempting to enable
> or disable the 5 Button Array. I'm not sure if this is normal,
> but the warning seems harmless.

Yes the warning should be harmless and adding more special handling
is not worth it IMHO.

Patch looks good to me:

Reviewed-by: Hans de Goede <hdegoede@...hat.com>

Regards,

Hans




> Co-developed-by: Mary Strodl <mstrodl@....rit.edu>
> Signed-off-by: Mary Strodl <mstrodl@....rit.edu>
> Signed-off-by: Cole Stowell <cole@...well.pro>
> ---
>  drivers/platform/x86/intel/hid.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/platform/x86/intel/hid.c b/drivers/platform/x86/intel/hid.c
> index 445e7a59beb4..48ad75a56199 100644
> --- a/drivers/platform/x86/intel/hid.c
> +++ b/drivers/platform/x86/intel/hid.c
> @@ -118,6 +118,13 @@ static const s
> truct dmi_system_id button_array_table[] = {
>  			DMI_MATCH(DMI_PRODUCT_NAME, "HP Spectre x2 Detachable"),
>  		},
>  	},
> +	{
> +		.ident = "Lenovo ThinkPad X1 Tablet Gen 1",
> +		.matches = {
> +			DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
> +			DMI_MATCH(DMI_PRODUCT_FAMILY, "ThinkPad X12 Detachable Gen 1"),
> +		},
> +	},
>  	{
>  		.ident = "Lenovo ThinkPad X1 Tablet Gen 2",
>  		.matches = {