linux-kernel - [PATCH] ARM: dts: ti/omap: gta04: fix pm issues caused by spi module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20241107225100.1803943-1-andreas@kemnade.info>
Date: Thu,  7 Nov 2024 23:51:00 +0100
From: Andreas Kemnade <andreas@...nade.info>
To: tony@...mide.com,
	robh@...nel.org,
	krzk+dt@...nel.org,
	conor+dt@...nel.org,
	andreas@...nade.info,
	hns@...delico.com,
	linux-omap@...r.kernel.org,
	devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	aaro.koskinen@....fi,
	khilman@...libre.com,
	rogerq@...nel.org
Cc: stable@...r.kernel.org
Subject: [PATCH] ARM: dts: ti/omap: gta04: fix pm issues caused by spi module

Despite CM_IDLEST1_CORE and CM_FCLKEN1_CORE behaving normal,
disabling SPI leads to messages like:
Powerdomain (core_pwrdm) didn't enter target state 0
and according to /sys/kernel/debug/pm_debug/count off state is not
entered. That was not connected to SPI during the discussion
of disabling SPI. See:
https://lore.kernel.org/linux-omap/20230122100852.32ae082c@aktux/

Fix excess DMA channel usage by disabling DMA only instead of disabling
the SPI modules, so powermanagement can da all its work.

Fixes: a622310f7f01 ("ARM: dts: gta04: fix excess dma channel usage")
CC: stable@...r.kernel.org
Signed-off-by: Andreas Kemnade <andreas@...nade.info>
---
 arch/arm/boot/dts/ti/omap/omap3-gta04.dtsi | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/arch/arm/boot/dts/ti/omap/omap3-gta04.dtsi b/arch/arm/boot/dts/ti/omap/omap3-gta04.dtsi
index 3661340009e7a..11f8af34498b1 100644
--- a/arch/arm/boot/dts/ti/omap/omap3-gta04.dtsi
+++ b/arch/arm/boot/dts/ti/omap/omap3-gta04.dtsi
@@ -612,19 +612,23 @@ &i2c3 {
 };
 
 &mcspi1 {
-	status = "disabled";
+	/delete-property/ dmas;
+	/delete-property/ dma-names;
 };
 
 &mcspi2 {
-	status = "disabled";
+	/delete-property/ dmas;
+	/delete-property/ dma-names;
 };
 
 &mcspi3 {
-	status = "disabled";
+	/delete-property/ dmas;
+	/delete-property/ dma-names;
 };
 
 &mcspi4 {
-	status = "disabled";
+	/delete-property/ dmas;
+	/delete-property/ dma-names;
 };
 
 &usb_otg_hs {
-- 
2.39.2