linux-kernel - Re: [PATCH] ARM: dts: ti/omap: gta04: fix pm issues caused by spi module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b26c1fa8-b3b7-4aa9-bc78-793ddfa3bc6b@kernel.org>
Date: Fri, 8 Nov 2024 14:42:14 +0200
From: Roger Quadros <rogerq@...nel.org>
To: Andreas Kemnade <andreas@...nade.info>, tony@...mide.com,
 robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org, hns@...delico.com,
 linux-omap@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, aaro.koskinen@....fi, khilman@...libre.com
Cc: stable@...r.kernel.org
Subject: Re: [PATCH] ARM: dts: ti/omap: gta04: fix pm issues caused by spi
 module

Hi,

On 08/11/2024 00:51, Andreas Kemnade wrote:
> Despite CM_IDLEST1_CORE and CM_FCLKEN1_CORE behaving normal,
> disabling SPI leads to messages like:
> Powerdomain (core_pwrdm) didn't enter target state 0
> and according to /sys/kernel/debug/pm_debug/count off state is not
> entered. That was not connected to SPI during the discussion
> of disabling SPI. See:
> https://lore.kernel.org/linux-omap/20230122100852.32ae082c@aktux/
> 
> Fix excess DMA channel usage by disabling DMA only instead of disabling
> the SPI modules, so powermanagement can da all its work.

s/powermanagement/power management
s/da/do

> 
> Fixes: a622310f7f01 ("ARM: dts: gta04: fix excess dma channel usage")
> CC: stable@...r.kernel.org
> Signed-off-by: Andreas Kemnade <andreas@...nade.info>
> ---
>  arch/arm/boot/dts/ti/omap/omap3-gta04.dtsi | 12 ++++++++----
>  1 file changed, 8 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/ti/omap/omap3-gta04.dtsi b/arch/arm/boot/dts/ti/omap/omap3-gta04.dtsi
> index 3661340009e7a..11f8af34498b1 100644
> --- a/arch/arm/boot/dts/ti/omap/omap3-gta04.dtsi
> +++ b/arch/arm/boot/dts/ti/omap/omap3-gta04.dtsi
> @@ -612,19 +612,23 @@ &i2c3 {
>  };
>  
>  &mcspi1 {
> -	status = "disabled";

But according to commit a622310f7f01 ("ARM: dts: gta04: fix excess dma channel usage"),
these mcspi modules are not used. So it doesn't make sense to enable them even if it
seems to solve the power management issue?

Does bootloader leave the mcspi modules in a unwanted state?
Would it make sense for the bus driver to explicitly turn off all modules?

> +	/delete-property/ dmas;
> +	/delete-property/ dma-names;
>  };
>  
>  &mcspi2 {
> -	status = "disabled";
> +	/delete-property/ dmas;
> +	/delete-property/ dma-names;
>  };
>  
>  &mcspi3 {
> -	status = "disabled";
> +	/delete-property/ dmas;
> +	/delete-property/ dma-names;
>  };
>  
>  &mcspi4 {
> -	status = "disabled";
> +	/delete-property/ dmas;
> +	/delete-property/ dma-names;
>  };
>  
>  &usb_otg_hs {

-- 
cheers,
-roger