linux-kernel - Re: [PATCH] arm64: dts: rockchip: orangepi-5-plus: Enable USB 3.0 ports

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <fzrnp55hcmszqcdc6m6qacfv4rka5tlvp3kpll5i6d6fjm2mc5@d6yo5c25gv6i>
Date: Fri, 8 Nov 2024 00:27:45 +0100
From: Ondřej Jirman <megi@....cz>
To: Chen-Yu Tsai <wens@...nel.org>
Cc: Heiko Stuebner <heiko@...ech.de>, Chen-Yu Tsai <wens@...e.org>, 
	devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, 
	linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arm64: dts: rockchip: orangepi-5-plus: Enable USB 3.0
 ports

Hi,

On Fri, Nov 08, 2024 at 12:16:57AM GMT, Chen-Yu Tsai wrote:
> On Mon, Oct 28, 2024 at 6:47 AM Ondřej Jirman <megi@....cz> wrote:
> >
> > > +
> > > +             usb_con: connector {
> > > +                     compatible = "usb-c-connector";
> > > +                     label = "USB-C";
> > > +                     data-role = "dual";
> > > +                     op-sink-microwatt = <1000000>;
> > > +                     power-role = "dual";
> > > +                     sink-pdos =
> > > +                             <PDO_FIXED(5000, 1000, PDO_FIXED_USB_COMM)>;
> >
> > The board can't sink power from this port. It's a source only port. So sink-pdos
> > can be lower, so that if you plug this into type-c hub as a peripheral, the hub
> > doesn't need to reserve 5W for this port.
> >
> > op-sink-microwat can also be lower. The port will not sink any power when
> > connected to 5V VBUS externally.
> >
> > Otherwise you can probably keep power-role = "dual";
> 
> I guess it should just be power-role = "source";
> And then drop all the sink related properties.

Probably not. The board is not powered from that port, but I should still be able
to plug it via that port to a PC, and in that case it should not act as power
source (vbus should be disabled), because PC's port will provide power. (say
via USB-A <-> USB-C cable connected to PC's USB host port)

It should still be capable of being in power sink mode on that port, but it will
just not physically sink anything. Just the board's vbus will be disabled.

We should just describe that in sink mode it will not sink much of anything.

> > > +                     source-pdos =
> > > +                             <PDO_FIXED(5000, 3000, PDO_FIXED_USB_COMM)>;
> >
> > This port can't source 3A. U22 (SY6280AAC) is configured via Rset for 1.44A
> > limit. So let's say 1.5A.
> 
> Probably 1.4A to be safe?

Ok.

> > > +&u2phy1 {
> > > +     status = "okay";
> > > +};
> > > +
> > > +&u2phy1_otg {
> >
> > Needs:
> >         phy-supply = <&vcc5v0_host>;
> 
> You probably mean vcc5v0_sys?

Sorry, ignore this request completely. I was mis-looking at quartzpro DTS, when
reviewing this part of the patch.

Thank you,
	o.