[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <bc49f1de-8cce-404d-927a-ebe606c99026@kernel.org>
Date: Thu, 7 Nov 2024 08:10:15 +0100
From: Jiri Slaby <jirislaby@...nel.org>
To: liujing <liujing@...s.chinamobile.com>, mpe@...erman.id.au
Cc: npiggin@...il.com, christophe.leroy@...roup.eu, naveen@...nel.org,
maddy@...ux.ibm.com, gregkh@...uxfoundation.org,
linuxppc-dev@...ts.ozlabs.org, linux-kernel@...r.kernel.org,
linux-serial@...r.kernel.org
Subject: Re: [PATCH] tty:hvc:Fix incorrect formatted output
On 07. 11. 24, 6:47, liujing wrote:
> The termno parameter is defined as an unsigned int
> in hvc_opal_probe function,
"The termno parameter is defined as an unsigned int in hvc_opal_probe()."
We place () after function names, then "function" is not needed.
> So when it output should be modified to %u format.
I cannot parse this. Perhaps:
"So when it is output, a %u specifier should be used for formatting."
? But feel free to use your own words, but somehow spell (or chatgpt)
check it.
> Signed-off-by: liujing <liujing@...s.chinamobile.com>
>
> diff --git a/drivers/tty/hvc/hvc_opal.c b/drivers/tty/hvc/hvc_opal.c
> index 095c33ad10f8..1d2e7f2ce088 100644
> --- a/drivers/tty/hvc/hvc_opal.c
> +++ b/drivers/tty/hvc/hvc_opal.c
> @@ -199,7 +199,7 @@ static int hvc_opal_probe(struct platform_device *dev)
> /* Instanciate now to establish a mapping index==vtermno */
> hvc_instantiate(termno, termno, ops);
> } else {
> - pr_err("hvc_opal: Device %pOF has duplicate terminal number #%d\n",
> + pr_err("hvc_opal: Device %pOF has duplicate terminal number #%u\n",
> dev->dev.of_node, termno);
There are more occurrences of this. Care to fix them all?
thanks,
--
js
suse labs
Powered by blists - more mailing lists