linux-kernel - Re: [PATCH] tty:hvc:Fix incorrect formatted output

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6fa97654-19f6-4c5b-8db5-e76aafcf4227@kernel.org>
Date: Thu, 7 Nov 2024 08:11:27 +0100
From: Jiri Slaby <jirislaby@...nel.org>
To: liujing <liujing@...s.chinamobile.com>, mpe@...erman.id.au
Cc: npiggin@...il.com, christophe.leroy@...roup.eu, naveen@...nel.org,
 maddy@...ux.ibm.com, gregkh@...uxfoundation.org,
 linuxppc-dev@...ts.ozlabs.org, linux-kernel@...r.kernel.org,
 linux-serial@...r.kernel.org
Subject: Re: [PATCH] tty:hvc:Fix incorrect formatted output

Also please fix the subject. See:
git log --oneline drivers/tty/hvc/hvc_opal.c

On 07. 11. 24, 8:10, Jiri Slaby wrote:
> On 07. 11. 24, 6:47, liujing wrote:
>> The termno parameter is defined as an unsigned int
>> in hvc_opal_probe function,
> 
> "The termno parameter is defined as an unsigned int in hvc_opal_probe()."
> 
> We place () after function names, then "function" is not needed.
> 
>  > So when it output should be modified to %u format.
> 
> I cannot parse this. Perhaps:
> "So when it is output, a %u specifier should be used for formatting."
> ? But feel free to use your own words, but somehow spell (or chatgpt) 
> check it.
> 
>> Signed-off-by: liujing <liujing@...s.chinamobile.com>
>>
>> diff --git a/drivers/tty/hvc/hvc_opal.c b/drivers/tty/hvc/hvc_opal.c
>> index 095c33ad10f8..1d2e7f2ce088 100644
>> --- a/drivers/tty/hvc/hvc_opal.c
>> +++ b/drivers/tty/hvc/hvc_opal.c
>> @@ -199,7 +199,7 @@ static int hvc_opal_probe(struct platform_device 
>> *dev)
>>           /* Instanciate now to establish a mapping index==vtermno */
>>           hvc_instantiate(termno, termno, ops);
>>       } else {
>> -        pr_err("hvc_opal: Device %pOF has duplicate terminal number 
>> #%d\n",
>> +        pr_err("hvc_opal: Device %pOF has duplicate terminal number 
>> #%u\n",
>>                  dev->dev.of_node, termno);
> 
> There are more occurrences of this. Care to fix them all?
> 
> thanks,

-- 
js
suse labs