linux-kernel - Re: [PATCH net-next 0/5] Add more feautues for ENETC v4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZyyEbCKxjkVFXUMB@test-OptiPlex-Tower-Plus-7010>
Date: Thu, 7 Nov 2024 14:42:12 +0530
From: Hariprasad Kelam <hkelam@...vell.com>
To: Wei Fang <wei.fang@....com>
CC: <claudiu.manoil@....com>, <vladimir.oltean@....com>,
        <xiaoning.wang@....com>, <andrew+netdev@...n.ch>,
        <davem@...emloft.net>, <edumazet@...gle.com>, <kuba@...nel.org>,
        <pabeni@...hat.com>, <netdev@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <imx@...ts.linux.dev>
Subject: Re: [PATCH net-next 0/5] Add more feautues for ENETC v4 - round 1

On 2024-11-07 at 09:08:12, Wei Fang (wei.fang@....com) wrote:
> Compared to ENETC v1 (LS1028A), ENETC v4 (i.MX95) adds more features, and
> some features are configured completely differently from v1. In order to
> more fully support ENETC v4, these features will be added through several
> rounds of patch sets. This round adds these features, such as Tx and Rx
> checksum offload, increase maximum chained Tx BD number and Large send
> offload (LSO).
> 
> Wei Fang (5):
>   net: enetc: add Rx checksum offload for i.MX95 ENETC
>   net: enetc: add Tx checksum offload for i.MX95 ENETC
>   net: enetc: update max chained Tx BD number for i.MX95 ENETC
>   net: enetc: add LSO support for i.MX95 ENETC PF
>   net: enetc: add UDP segmentation offload support
>

Can you refactor the patches in a way that "ndev->hw_features" set 
in corresponding patch.


Setting NETIF_F_HW_CSUM in "net: enetc: add UDP segmentation offload
support" does not look good to me.

Thanks,
Hariprasad k


>  drivers/net/ethernet/freescale/enetc/enetc.c  | 345 ++++++++++++++++--
>  drivers/net/ethernet/freescale/enetc/enetc.h  |  32 +-
>  .../net/ethernet/freescale/enetc/enetc4_hw.h  |  22 ++
>  .../net/ethernet/freescale/enetc/enetc_hw.h   |  31 +-
>  .../freescale/enetc/enetc_pf_common.c         |  16 +-
>  .../net/ethernet/freescale/enetc/enetc_vf.c   |   7 +-
>  6 files changed, 419 insertions(+), 34 deletions(-)
> 
> -- 
> 2.34.1
> 
>