linux-kernel - RE: [PATCH net-next 0/5] Add more feautues for ENETC v4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <PAXPR04MB8510B19BBCC8110A4E45C12F885C2@PAXPR04MB8510.eurprd04.prod.outlook.com>
Date: Thu, 7 Nov 2024 09:52:44 +0000
From: Wei Fang <wei.fang@....com>
To: Hariprasad Kelam <hkelam@...vell.com>
CC: Claudiu Manoil <claudiu.manoil@....com>, Vladimir Oltean
	<vladimir.oltean@....com>, Clark Wang <xiaoning.wang@....com>,
	"andrew+netdev@...n.ch" <andrew+netdev@...n.ch>, "davem@...emloft.net"
	<davem@...emloft.net>, "edumazet@...gle.com" <edumazet@...gle.com>,
	"kuba@...nel.org" <kuba@...nel.org>, "pabeni@...hat.com" <pabeni@...hat.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"imx@...ts.linux.dev" <imx@...ts.linux.dev>
Subject: RE: [PATCH net-next 0/5] Add more feautues for ENETC v4 - round 1

> -----Original Message-----
> From: Hariprasad Kelam <hkelam@...vell.com>
> Sent: 2024年11月7日 17:12
> To: Wei Fang <wei.fang@....com>
> Cc: Claudiu Manoil <claudiu.manoil@....com>; Vladimir Oltean
> <vladimir.oltean@....com>; Clark Wang <xiaoning.wang@....com>;
> andrew+netdev@...n.ch; davem@...emloft.net; edumazet@...gle.com;
> kuba@...nel.org; pabeni@...hat.com; netdev@...r.kernel.org;
> linux-kernel@...r.kernel.org; imx@...ts.linux.dev
> Subject: Re: [PATCH net-next 0/5] Add more feautues for ENETC v4 - round 1
> 
> On 2024-11-07 at 09:08:12, Wei Fang (wei.fang@....com) wrote:
> > Compared to ENETC v1 (LS1028A), ENETC v4 (i.MX95) adds more features,
> > and some features are configured completely differently from v1. In
> > order to more fully support ENETC v4, these features will be added
> > through several rounds of patch sets. This round adds these features,
> > such as Tx and Rx checksum offload, increase maximum chained Tx BD
> > number and Large send offload (LSO).
> >
> > Wei Fang (5):
> >   net: enetc: add Rx checksum offload for i.MX95 ENETC
> >   net: enetc: add Tx checksum offload for i.MX95 ENETC
> >   net: enetc: update max chained Tx BD number for i.MX95 ENETC
> >   net: enetc: add LSO support for i.MX95 ENETC PF
> >   net: enetc: add UDP segmentation offload support
> >
> 
> Can you refactor the patches in a way that "ndev->hw_features" set in
> corresponding patch.
> 
> 
> Setting NETIF_F_HW_CSUM in "net: enetc: add UDP segmentation offload
> support" does not look good to me.
> 

Sorry, I don't quite understand. I only set NETIF_F_GSO_UDP_L4 in the patch.
NETIF_F_HW_CSUM was already set before this patch set.