linux-kernel - Re: [PATCH V1 1/3] dt-bindings: mmc: qcom: Document level shifter flag for SD card

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <173097168998.1358564.6585218093768664587.robh@kernel.org>
Date: Thu, 07 Nov 2024 03:28:10 -0600
From: "Rob Herring (Arm)" <robh@...nel.org>
To: Sarthak Garg <quic_sartgarg@...cinc.com>
Cc: Adrian Hunter <adrian.hunter@...el.com>, quic_rampraka@...cinc.com, 
 Conor Dooley <conor+dt@...nel.org>, quic_nguyenb@...cinc.com, 
 Ulf Hansson <ulf.hansson@...aro.org>, linux-kernel@...r.kernel.org, 
 quic_pragalla@...cinc.com, quic_bhaskarv@...cinc.com, 
 Krzysztof Kozlowski <krzk+dt@...nel.org>, quic_sachgupt@...cinc.com, 
 Bhupesh Sharma <bhupesh.sharma@...aro.org>, devicetree@...r.kernel.org, 
 quic_nitirawa@...cinc.com, quic_cang@...cinc.com, quic_narepall@...cinc.com, 
 quic_sayalil@...cinc.com, linux-mmc@...r.kernel.org, kernel@...cinc.com, 
 linux-arm-msm@...r.kernel.org
Subject: Re: [PATCH V1 1/3] dt-bindings: mmc: qcom: Document level shifter
 flag for SD card


On Thu, 07 Nov 2024 13:35:03 +0530, Sarthak Garg wrote:
> Introduce a flag to indicate if the Qualcomm platform has a level
> shifter for SD cards. With level shifter addition some extra delay is
> seen on RX data path leading to CRC errors. To compensate these delays
> and avoid CRC errors below things needs to be done:
> 
> 1) Enable tuning for SDR50 mode
> 2) Limit HS mode frequency to 37.5MHz from 50MHz
> 
> Add this flag for all targets with a level shifter to handle these
> issues for SD card.
> 
> Signed-off-by: Sarthak Garg <quic_sartgarg@...cinc.com>
> ---
>  Documentation/devicetree/bindings/mmc/sdhci-msm.yaml | 3 +++
>  1 file changed, 3 insertions(+)
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml: qcom,use-level-shifter: missing type definition

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20241107080505.29244-2-quic_sartgarg@quicinc.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.