linux-kernel - Re: [PATCH v5 1/1] x86/cpu: Make sure flag_is_changeable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4A528893-A428-4A6F-8672-1D14CC57F696@zytor.com>
Date: Fri, 08 Nov 2024 16:48:16 +0100
From: "H. Peter Anvin" <hpa@...or.com>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
CC: Thomas Gleixner <tglx@...utronix.de>, linux-kernel@...r.kernel.org,
        llvm@...ts.linux.dev, Ingo Molnar <mingo@...hat.com>,
        Borislav Petkov <bp@...en8.de>,
        Dave Hansen <dave.hansen@...ux.intel.com>, x86@...nel.org,
        Nathan Chancellor <nathan@...nel.org>,
        Nick Desaulniers <ndesaulniers@...gle.com>,
        Bill Wendling <morbo@...gle.com>,
        Justin Stitt <justinstitt@...gle.com>,
        Dave Hansen <dave.hansen@...el.com>
Subject: Re: [PATCH v5 1/1] x86/cpu: Make sure flag_is_changeable_p() is always being used

On November 8, 2024 4:41:16 PM GMT+01:00, Andy Shevchenko <andriy.shevchenko@...ux.intel.com> wrote:
>On Fri, Nov 08, 2024 at 04:35:17PM +0100, H. Peter Anvin wrote:
>> On November 8, 2024 4:30:10 PM GMT+01:00, Andy Shevchenko <andriy.shevchenko@...ux.intel.com> wrote:
>
>> >See also commit 6863f5643dd7 ("kbuild: allow Clang to find unused static
>> >inline functions for W=1 build").
>
>^^^ (1)
>
>> Looks good to me:
>> 
>> Reviewed-by: H. Peter Anvin (Intel) <hpa@...or.com>
>
>Thank you!
>
>> But another question: why the hell does clang complain about an unused static inline function?!
>
>Does (1) shed a bit of light to this?
>

How on earth is that supposed to work?! We have static inline functions in headers all over the place that are only used in certain circumstances. 

Is this a good thing, really? Or is it noise?