linux-kernel - Re: [PATCH v4 1/6] kvm: svm: Fix gctx page leak on invalid inputs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <68770651-f7cc-4032-aabc-90c72ee648a6@redhat.com>
Date: Fri, 8 Nov 2024 10:08:32 +0100
From: Paolo Bonzini <pbonzini@...hat.com>
To: Tom Lendacky <thomas.lendacky@....com>,
 Dionna Glaze <dionnaglaze@...gle.com>, x86@...nel.org,
 linux-kernel@...r.kernel.org, Sean Christopherson <seanjc@...gle.com>,
 Thomas Gleixner <tglx@...utronix.de>, Ingo Molnar <mingo@...hat.com>,
 Borislav Petkov <bp@...en8.de>, Dave Hansen <dave.hansen@...ux.intel.com>,
 "H. Peter Anvin" <hpa@...or.com>, Michael Roth <michael.roth@....com>,
 Brijesh Singh <brijesh.singh@....com>, Ashish Kalra <ashish.kalra@....com>
Cc: John Allen <john.allen@....com>, Herbert Xu
 <herbert@...dor.apana.org.au>, "David S. Miller" <davem@...emloft.net>,
 Luis Chamberlain <mcgrof@...nel.org>, Russ Weight <russ.weight@...ux.dev>,
 Danilo Krummrich <dakr@...hat.com>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 "Rafael J. Wysocki" <rafael@...nel.org>,
 Tianfei zhang <tianfei.zhang@...el.com>, Alexey Kardashevskiy <aik@....com>,
 kvm@...r.kernel.org
Subject: Re: [PATCH v4 1/6] kvm: svm: Fix gctx page leak on invalid inputs

On 11/6/24 15:29, Tom Lendacky wrote:
> On 11/4/24 19:05, Dionna Glaze wrote:
>> Ensure that snp gctx page allocation is adequately deallocated on
>> failure during snp_launch_start.
>>
>> Fixes: 136d8bc931c8 ("KVM: SEV: Add KVM_SEV_SNP_LAUNCH_START command")
>>
>> CC: Sean Christopherson <seanjc@...gle.com>
>> CC: Paolo Bonzini <pbonzini@...hat.com>
>> CC: Thomas Gleixner <tglx@...utronix.de>
>> CC: Ingo Molnar <mingo@...hat.com>
>> CC: Borislav Petkov <bp@...en8.de>
>> CC: Dave Hansen <dave.hansen@...ux.intel.com>
>> CC: Ashish Kalra <ashish.kalra@....com>
>> CC: Tom Lendacky <thomas.lendacky@....com>
>> CC: John Allen <john.allen@....com>
>> CC: Herbert Xu <herbert@...dor.apana.org.au>
>> CC: "David S. Miller" <davem@...emloft.net>
>> CC: Michael Roth <michael.roth@....com>
>> CC: Luis Chamberlain <mcgrof@...nel.org>
>> CC: Russ Weight <russ.weight@...ux.dev>
>> CC: Danilo Krummrich <dakr@...hat.com>
>> CC: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
>> CC: "Rafael J. Wysocki" <rafael@...nel.org>
>> CC: Tianfei zhang <tianfei.zhang@...el.com>
>> CC: Alexey Kardashevskiy <aik@....com>
>>
>> Signed-off-by: Dionna Glaze <dionnaglaze@...gle.com>
> 
> Reviewed-by: Tom Lendacky <thomas.lendacky@....com>
> 
>> ---
>>   arch/x86/kvm/svm/sev.c | 8 ++++----
>>   1 file changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/arch/x86/kvm/svm/sev.c b/arch/x86/kvm/svm/sev.c
>> index 714c517dd4b72..f6e96ec0a5caa 100644
>> --- a/arch/x86/kvm/svm/sev.c
>> +++ b/arch/x86/kvm/svm/sev.c
>> @@ -2212,10 +2212,6 @@ static int snp_launch_start(struct kvm *kvm, struct kvm_sev_cmd *argp)
>>   	if (sev->snp_context)
>>   		return -EINVAL;
>>   
>> -	sev->snp_context = snp_context_create(kvm, argp);
>> -	if (!sev->snp_context)
>> -		return -ENOTTY;
>> -
>>   	if (params.flags)
>>   		return -EINVAL;
>>   
>> @@ -2230,6 +2226,10 @@ static int snp_launch_start(struct kvm *kvm, struct kvm_sev_cmd *argp)
>>   	if (params.policy & SNP_POLICY_MASK_SINGLE_SOCKET)
>>   		return -EINVAL;
>>   
>> +	sev->snp_context = snp_context_create(kvm, argp);
>> +	if (!sev->snp_context)
>> +		return -ENOTTY;
>> +
>>   	start.gctx_paddr = __psp_pa(sev->snp_context);
>>   	start.policy = params.policy;
>>   	memcpy(start.gosvw, params.gosvw, sizeof(params.gosvw));
> 

Applied, thanks.

Paolo