linux-kernel - Re: [PATCH 2/3] arm64: dts: freescale: Add i.MX91 dtsi support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Zy3gXvuWb76beZKo@pengfei-OptiPlex-Tower-Plus-7010>
Date: Fri, 8 Nov 2024 17:56:46 +0800
From: Pengfei Li <pengfei.li_1@....com>
To: Alexander Stein <alexander.stein@...tq-group.com>
Cc: robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org,
	shawnguo@...nel.org, s.hauer@...gutronix.de, kernel@...gutronix.de,
	festevam@...il.com, joao.goncalves@...adex.com,
	frieder.schrempf@...tron.de, marex@...x.de,
	hvilleneuve@...onoff.com, peng.fan@....com, m.othacehe@...il.com,
	mwalle@...nel.org, Max.Merchel@...tq-group.com,
	hiago.franco@...adex.com, tharvey@...eworks.com,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	imx@...ts.linux.dev, linux-arm-kernel@...ts.infradead.org,
	ping.bai@....com, ye.li@....com, aisheng.dong@....com,
	frank.li@....com
Subject: Re: [PATCH 2/3] arm64: dts: freescale: Add i.MX91 dtsi support

On Thu, Nov 07, 2024 at 01:49:50PM +0100, Alexander Stein wrote:
> Hi,
> 
> thanks for putting me on CC.
> 
> Am Freitag, 8. November 2024, 03:27:02 CET schrieb Pengfei Li:
> > The i.MX 91 family features an Arm Cortex-A55 running at up to
> > 1.4GHz, support for modern LPDDR4 memory to enable platform longevity,
> > along with a rich set of peripherals targeting medical, industrial
> > and consumer IoT market segments.
> > 
> > The design of the i.MX91 platform is very similar to i.MX93.
> > The mainly difference between i.MX91 and i.MX93 is as follows:
> > - i.MX91 removed some clocks and modified the names of some clocks.
> > - i.MX91 only has one A core
> > 
> > Signed-off-by: Pengfei Li <pengfei.li_1@....com>
> > Reviewed-by: Frank Li <Frank.Li@....com>
> > ---
> >  arch/arm64/boot/dts/freescale/imx91-pinfunc.h | 770 ++++++++++++++++++
> >  arch/arm64/boot/dts/freescale/imx91.dtsi      |  66 ++
> >  2 files changed, 836 insertions(+)
> >  create mode 100644 arch/arm64/boot/dts/freescale/imx91-pinfunc.h
> >  create mode 100644 arch/arm64/boot/dts/freescale/imx91.dtsi
> > 
> > diff --git a/arch/arm64/boot/dts/freescale/imx91-pinfunc.h b/arch/arm64/boot/dts/freescale/imx91-pinfunc.h
> > new file mode 100644
> > index 000000000000..bc58ce2102b2
> > --- /dev/null
> > +++ b/arch/arm64/boot/dts/freescale/imx91-pinfunc.h
> 
> FWIW this is a 1:1 copy from downstream kernel

Hi, thanks for the comments.

Yes, it is same as downstream kernel.

> 
> > diff --git a/arch/arm64/boot/dts/freescale/imx91.dtsi b/arch/arm64/boot/dts/freescale/imx91.dtsi
> > new file mode 100644
> > index 000000000000..a9f4c1fe61cc
> > --- /dev/null
> > +++ b/arch/arm64/boot/dts/freescale/imx91.dtsi
> > @@ -0,0 +1,66 @@
> > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> > +/*
> > + * Copyright 2024 NXP
> > + */
> > +
> > +#include "imx91-pinfunc.h"
> > +#include "imx93.dtsi"
> > +
> > +&{/thermal-zones/cpu-thermal/cooling-maps/map0} {
> > +	cooling-device =
> > +		<&A55_0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;
> > +};
> > +
> > +&clk {
> > +	compatible = "fsl,imx91-ccm";
> > +};
> > +
> > +&eqos {
> > +	clocks = <&clk IMX91_CLK_ENET1_QOS_TSN_GATE>,
> > +			<&clk IMX91_CLK_ENET1_QOS_TSN_GATE>,
> > +			<&clk IMX91_CLK_ENET_TIMER>,
> > +			<&clk IMX91_CLK_ENET1_QOS_TSN>,
> > +			<&clk IMX91_CLK_ENET1_QOS_TSN_GATE>;
> > +	assigned-clocks = <&clk IMX91_CLK_ENET_TIMER>,
> > +				<&clk IMX91_CLK_ENET1_QOS_TSN>;
> > +	assigned-clock-parents = <&clk IMX93_CLK_SYS_PLL_PFD1_DIV2>,
> > +					<&clk IMX93_CLK_SYS_PLL_PFD0_DIV2>;
> 
> Is it just me or is the alignment of new lines not matching?

Not sure about others, the alignment on my side is correct.

> 
> 
> > +};
> > +
> > +&fec {
> > +	clocks = <&clk IMX91_CLK_ENET2_REGULAR_GATE>,
> > +			<&clk IMX91_CLK_ENET2_REGULAR_GATE>,
> > +			<&clk IMX91_CLK_ENET_TIMER>,
> > +			<&clk IMX91_CLK_ENET2_REGULAR>,
> > +			<&clk IMX93_CLK_DUMMY>;
> > +	assigned-clocks = <&clk IMX91_CLK_ENET_TIMER>,
> > +				<&clk IMX91_CLK_ENET2_REGULAR>;
> > +	assigned-clock-parents = <&clk IMX93_CLK_SYS_PLL_PFD1_DIV2>,
> > +					<&clk IMX93_CLK_SYS_PLL_PFD0_DIV2>;
> 
> Here as well: Is it just me or is the alignment of new lines not matching?

Same as above.

> 
> > +	assigned-clock-rates = <100000000>, <250000000>;
> > +};
> > +
> > +&i3c1 {
> > +	clocks = <&clk IMX93_CLK_BUS_AON>,
> > +			<&clk IMX93_CLK_I3C1_GATE>,
> > +			<&clk IMX93_CLK_DUMMY>;
> > +};
> > +
> > +&i3c2 {
> > +	clocks = <&clk IMX93_CLK_BUS_WAKEUP>,
> > +			<&clk IMX93_CLK_I3C2_GATE>,
> > +			<&clk IMX93_CLK_DUMMY>;
> > +};
> > +
> > +&tmu {
> > +	status = "disabled";
> 
> Why does the TMU needs to be disabled instead of deleted?

Actually, the i.MX91 also has a TMU, but the i.MX91 uses a different IP than the i.MX93, so a new driver is required.
However, this new driver is not applied yet on upstream kernel, so it is disabled here for now.

> 
> > +};
> > +
> > +/* i.MX91 only has one A core */
> > +/delete-node/ &A55_1;
> > +
> > +/* i.MX91 not has cm33 */
> > +/delete-node/ &cm33;
> > +
> > +/* i.MX91 not has power-domain@...61800 */
> > +/delete-node/ &mlmix;
> > 
> 
> Shouldn't the following node also be removed?
> * mipi_csi
> * dsi
> * lvds_bridge
> * lcdif_to_dsi
> * lcdif_to_ldb
> 
> Also in downstream kernel IMX91_CLK_MEDIA_AXI, which is IMX93_CLK_MEDIA_AXI
> upstream, is set to 200 MHz. Is this applicable here as well?
> 

For these nodes, it is only in the downstream kernel and not yet applied to the upstream kernel for i.MX93.
So they cannot be removed in the upstream kernel yet.

BR,
Pengfei Li

> Best regards,
> Alexander
> 
> -- 
> TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
> Amtsgericht München, HRB 105018
> Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
> http://www.tq-group.com/
> 
> 
>