linux-kernel - Re: [PATCH v4 3/6] arm64: Add Blaize BLZP1600 SoC family

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3ed7ac41-1f07-4711-a816-7dcf06f4cda4@linaro.org>
Date: Fri, 8 Nov 2024 11:57:03 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Niko Pasaloukos <nikolaos.pasaloukos@...ize.com>,
 James Cowgill <james.cowgill@...ize.com>,
 Matt Redfearn <matthew.redfearn@...ize.com>,
 Neil Jones <neil.jones@...ize.com>, "robh@...nel.org" <robh@...nel.org>,
 "krzysztof.kozlowski+dt@...aro.org" <krzysztof.kozlowski+dt@...aro.org>,
 "conor+dt@...nel.org" <conor+dt@...nel.org>,
 "catalin.marinas@....com" <catalin.marinas@....com>,
 "will@...nel.org" <will@...nel.org>, "arnd@...db.de" <arnd@...db.de>,
 "olof@...om.net" <olof@...om.net>,
 "hverkuil-cisco@...all.nl" <hverkuil-cisco@...all.nl>,
 "shawnguo@...nel.org" <shawnguo@...nel.org>,
 "hvilleneuve@...onoff.com" <hvilleneuve@...onoff.com>,
 "andre.przywara@....com" <andre.przywara@....com>,
 "rafal@...ecki.pl" <rafal@...ecki.pl>,
 "andersson@...nel.org" <andersson@...nel.org>,
 "konrad.dybcio@...aro.org" <konrad.dybcio@...aro.org>,
 "angelogioacchino.delregno@...labora.com"
 <angelogioacchino.delregno@...labora.com>, "nm@...com" <nm@...com>,
 "neil.armstrong@...aro.org" <neil.armstrong@...aro.org>,
 "nfraprado@...labora.com" <nfraprado@...labora.com>,
 "johan+linaro@...nel.org" <johan+linaro@...nel.org>
Cc: "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
 "linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v4 3/6] arm64: Add Blaize BLZP1600 SoC family

On 08/11/2024 11:31, Niko Pasaloukos wrote:
> Add ARCH_BLAIZE_BLZP1600 SoC family to the arm64 architecture.
> 
> Resolves: PESW-2604
> Checkpatch: ignore

NAK.

Please run scripts/checkpatch.pl and fix reported warnings. Then please
run `scripts/checkpatch.pl --strict` and (probably) fix more warnings.
Some warnings can be ignored, especially from --strict run, but the code
here looks like it needs a fix. Feel free to get in touch if the warning
is not clear.

> 
> Reviewed-by: James Cowgill <james.cowgill@...ize.com>
> Reviewed-by: Matt Redfearn <matt.redfearn@...ize.com>
> Reviewed-by: Neil Jones <neil.jones@...ize.com>

Are these real reviews?

Best regards,
Krzysztof