linux-kernel - Re: [PATCH v4 0/3] Replace the use of simple

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20241108110639.GA118048@lichtman.org>
Date: Fri, 8 Nov 2024 11:06:39 +0000
From: Nir Lichtman <nir@...htman.org>
To: Daniel Thompson <daniel.thompson@...aro.org>
Cc: kgdb-bugreport@...ts.sourceforge.net,
	linux-trace-kernel@...r.kernel.org, yuran.pereira@...mail.com,
	jason.wessel@...driver.com, dianders@...omium.org,
	rostedt@...dmis.org, mhiramat@...nel.org,
	linux-kernel@...r.kernel.org,
	linux-kernel-mentees@...ts.linuxfoundation.org
Subject: Re: [PATCH v4 0/3] Replace the use of simple_strtol/ul functions
 with kstrto

On Fri, Nov 08, 2024 at 08:38:35AM +0000, Daniel Thompson wrote:
> 
> On Mon, 28 Oct 2024 19:17:00 +0000, Nir Lichtman wrote:
> > The simple_str* family of functions perform no error checking in
> > scenarios where the input value overflows the intended output variable.
> > This results in these function successfully returning even when the
> > output does not match the input string.
> > 
> > Or as it was mentioned [1], "...simple_strtol(), simple_strtoll(),
> > simple_strtoul(), and simple_strtoull() functions explicitly ignore
> > overflows, which may lead to unexpected results in callers."
> > Hence, the use of those functions is discouraged.
> > 
> > [...]
> 
> Applied, thanks!

Thanks!

Nir