linux-kernel - Re: [PATCH] mtd: ubi: remove redundant check on bytes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <56b13d09-91ce-6a4b-c6cb-449b478e3335@huawei.com>
Date: Fri, 8 Nov 2024 09:41:44 +0800
From: Zhihao Cheng <chengzhihao1@...wei.com>
To: Colin Ian King <colin.i.king@...il.com>, Richard Weinberger
	<richard@....at>, Miquel Raynal <miquel.raynal@...tlin.com>, Vignesh
 Raghavendra <vigneshr@...com>, <linux-mtd@...ts.infradead.org>
CC: <kernel-janitors@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mtd: ubi: remove redundant check on bytes_left at end of
 function

在 2024/11/7 23:23, Colin Ian King 写道:
> In function ubi_nvmem_reg_read the while-loop can only be exiting
> of bytes_left is zero or an error has occurred. There is an exit
> return path if an error occurs, so the bytes_left can only be
> zero after that point. Hence the check for a non-zero bytes_left
> at the end of the function is redundant and can be removed. Remove
> the check and just return 0.
> 
> Signed-off-by: Colin Ian King <colin.i.king@...il.com>
> ---
>   drivers/mtd/ubi/nvmem.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
Make sense.
Reviewed-by: Zhihao Cheng <chengzhihao1@...wei.com>
> diff --git a/drivers/mtd/ubi/nvmem.c b/drivers/mtd/ubi/nvmem.c
> index a94a1a9aaec1..34f8c1d3cdee 100644
> --- a/drivers/mtd/ubi/nvmem.c
> +++ b/drivers/mtd/ubi/nvmem.c
> @@ -55,7 +55,7 @@ static int ubi_nvmem_reg_read(void *priv, unsigned int from,
>   	if (err)
>   		return err;
>   
> -	return bytes_left == 0 ? 0 : -EIO;
> +	return 0;
>   }
>   
>   static int ubi_nvmem_add(struct ubi_volume_info *vi)
>