linux-kernel - Re: [PATCH v4 1/2] PCI: mediatek-gen3: Add support for setting max-link-speed limit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c5385db34878763ba7df3711a514e4332418cbbd.camel@mediatek.com>
Date: Fri, 8 Nov 2024 01:43:44 +0000
From: Jianjun Wang (王建军) <Jianjun.Wang@...iatek.com>
To: "kw@...ux.com" <kw@...ux.com>, AngeloGioacchino Del Regno
	<angelogioacchino.delregno@...labora.com>
CC: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-mediatek@...ts.infradead.org" <linux-mediatek@...ts.infradead.org>,
	"kernel@...labora.com" <kernel@...labora.com>,
	"manivannan.sadhasivam@...aro.org" <manivannan.sadhasivam@...aro.org>,
	"robh@...nel.org" <robh@...nel.org>, "linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "matthias.bgg@...il.com"
	<matthias.bgg@...il.com>, "linux-pci@...r.kernel.org"
	<linux-pci@...r.kernel.org>, "lpieralisi@...nel.org" <lpieralisi@...nel.org>,
	Ryder Lee <Ryder.Lee@...iatek.com>, "fshao@...omium.org"
	<fshao@...omium.org>, "bhelgaas@...gle.com" <bhelgaas@...gle.com>
Subject: Re: [PATCH v4 1/2] PCI: mediatek-gen3: Add support for setting
 max-link-speed limit

Hi Krzysztof,

On Mon, 2024-11-04 at 22:25 +0900, Krzysztof Wilczyński wrote:
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
> 
> 
> Hello,
> 
> > > I wonder if this debug message would be better served as a
> > > warning to let
> > > the user know that the speed has been overridden due to the
> > > platform
> > > limitation.  Thoughts?
> > > 
> > > Also, there is no need to sent a new series if you fine with the
> > > suggestions.  I will mend the code on the branch when applying.
> > > 
> > 
> > A warning seems to be a bit too much and would appear like
> > something to worry
> > about (or something unintended)...
> > 
> > Perhaps a dev_info() would work better here?
> 
> Sounds good!  Thank you!
> 
> Will handle the necessary changes while applying the series.
> 
>         Krzysztof

This patch may need more discussion. I have replied in the previous
version:

https://lore.kernel.org/linux-pci/7e220693f076c84cc1bc3d91e797580b320b4598.camel@mediatek.com/T/#m1b9f2d26a228712b6b9d02eba11d8063862772c1

Should we wait longer before applying this patch? Do you have any
suggestions? I can provide more logs or test results if needed. Sorry
for the inconvenience.

Thanks.

>