linux-kernel - Re: [PATCH] parse_options(): replace deprecated strcpy with strscpy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAGiJo8Qd_Xd=u-Q84dpR6krU-svVjgA1hHdPHBr9kHkMwpX8qA@mail.gmail.com>
Date: Fri, 8 Nov 2024 17:40:19 -0800
From: Daniel Yang <danielyangkang@...il.com>
To: Chao Yu <chao@...nel.org>
Cc: Jaegeuk Kim <jaegeuk@...nel.org>, 
	"open list:F2FS FILE SYSTEM" <linux-f2fs-devel@...ts.sourceforge.net>, 
	open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] parse_options(): replace deprecated strcpy with strscpy

On Fri, Nov 8, 2024 at 1:47 AM Chao Yu <chao@...nel.org> wrote:
>
> On 2024/11/6 10:58, Daniel Yang wrote:
> > strcpy is deprecated. Kernel docs recommend replacing strcpy with
> > strscpy. The function strcpy() return value isn't used so there
> > shouldn't be an issue replacing with the safer alternative strscpy.
>
> It's better to add "f2fs: " prefix for commit title.
>
> >
> > Signed-off-by: Daniel Yang <danielyangkang@...il.com>
> > ---
> >   fs/f2fs/super.c | 4 ++--
> >   1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
> > index 87ab5696b..ee8861b95 100644
> > --- a/fs/f2fs/super.c
> > +++ b/fs/f2fs/super.c
> > @@ -1158,7 +1158,7 @@ static int parse_options(struct super_block *sb, char *options, bool is_remount)
> >                               break;
> >                       }
> >
> > -                     strcpy(ext[ext_cnt], name);
> > +                     strscpy(ext[ext_cnt], name);
>
> Needs to handle return value of strscpy()?
>
> >                       F2FS_OPTION(sbi).compress_ext_cnt++;
> >                       kfree(name);
> >                       break;
> > @@ -1187,7 +1187,7 @@ static int parse_options(struct super_block *sb, char *options, bool is_remount)
> >                               break;
> >                       }
> >
> > -                     strcpy(noext[noext_cnt], name);
> > +                     strscpy(noext[noext_cnt], name);
>
> Ditto,
>
> Thanks,
>
> >                       F2FS_OPTION(sbi).nocompress_ext_cnt++;
> >                       kfree(name);
> >                       break;
>

Ok, I've added the changes and sent a v2 of the patch. Lmk if there's
any other issues.

- Daniel