linux-kernel - Re: [PATCH] media: cec: extron-da-hd-4k-plus: add return check for wait_for

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202411102341.VuOHMHGh-lkp@intel.com>
Date: Sun, 10 Nov 2024 23:52:34 +0800
From: kernel test robot <lkp@...el.com>
To: Karol Przybylski <karprzy7@...il.com>, hverkuil@...all.nl,
	mchehab@...nel.org
Cc: oe-kbuild-all@...ts.linux.dev, Karol Przybylski <karprzy7@...il.com>,
	linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
	skhan@...uxfoundation.org
Subject: Re: [PATCH] media: cec: extron-da-hd-4k-plus: add return check for
 wait_for_completion*()

Hi Karol,

kernel test robot noticed the following build errors:

[auto build test ERROR on linuxtv-media-stage/master]
[also build test ERROR on linus/master v6.12-rc6 next-20241108]
[cannot apply to media-tree/master sailus-media-tree/streams sailus-media-tree/master]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Karol-Przybylski/media-cec-extron-da-hd-4k-plus-add-return-check-for-wait_for_completion/20241110-210018
base:   https://git.linuxtv.org/media_stage.git master
patch link:    https://lore.kernel.org/r/20241110125814.1899076-1-karprzy7%40gmail.com
patch subject: [PATCH] media: cec: extron-da-hd-4k-plus: add return check for wait_for_completion*()
config: s390-allyesconfig (https://download.01.org/0day-ci/archive/20241110/202411102341.VuOHMHGh-lkp@intel.com/config)
compiler: s390-linux-gcc (GCC) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241110/202411102341.VuOHMHGh-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202411102341.VuOHMHGh-lkp@intel.com/

All errors (new ones prefixed by >>):

   drivers/media/cec/usb/extron-da-hd-4k-plus/extron-da-hd-4k-plus.c: In function 'extron_read_edid':
>> drivers/media/cec/usb/extron-da-hd-4k-plus/extron-da-hd-4k-plus.c:563:17: error: 'ret' undeclared (first use in this function); did you mean 'net'?
     563 |                 ret = wait_for_completion_killable_timeout(&extron->edid_completion,
         |                 ^~~
         |                 net
   drivers/media/cec/usb/extron-da-hd-4k-plus/extron-da-hd-4k-plus.c:563:17: note: each undeclared identifier is reported only once for each function it appears in


vim +563 drivers/media/cec/usb/extron-da-hd-4k-plus/extron-da-hd-4k-plus.c

   540	
   541	static void extron_read_edid(struct extron_port *port)
   542	{
   543		struct extron *extron = port->extron;
   544		char cmd[10], reply[10];
   545		unsigned int idx;
   546	
   547		idx = port->port.port + (port->is_input ? 0 : extron->num_in_ports);
   548		snprintf(cmd, sizeof(cmd), "WR%uEDID", idx);
   549		snprintf(reply, sizeof(reply), "EdidR%u", idx);
   550		if (mutex_lock_interruptible(&extron->edid_lock))
   551			return;
   552		if (port->read_edid)
   553			goto unlock;
   554		extron->edid_bytes_read = 0;
   555		extron->edid_port = port;
   556		port->edid_blocks = 0;
   557		if (!port->has_edid)
   558			goto no_edid;
   559	
   560		extron->edid_reading = true;
   561	
   562		if (!extron_send_and_wait(extron, port, cmd, reply)) {
 > 563			ret = wait_for_completion_killable_timeout(&extron->edid_completion,
   564							     msecs_to_jiffies(1000));
   565			if (ret < 0)
   566				goto unlock;
   567		}
   568		if (port->edid_blocks) {
   569			extron_parse_edid(port);
   570			port->read_edid = true;
   571			if (!port->is_input)
   572				v4l2_ctrl_s_ctrl(port->ctrl_tx_edid_present, 1);
   573		}
   574	no_edid:
   575		extron->edid_reading = false;
   576	unlock:
   577		mutex_unlock(&extron->edid_lock);
   578		cancel_delayed_work_sync(&extron->work_update_edid);
   579		if (manufacturer_name[0])
   580			schedule_delayed_work(&extron->work_update_edid,
   581					      msecs_to_jiffies(1000));
   582	}
   583	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki