linux-kernel - RE: [PATCH v2 06/25] ASoC: sh: rz-ssi: Terminate all the DMA transactions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <TYCPR01MB1133233B458F3AC5F7C3602B3865F2@TYCPR01MB11332.jpnprd01.prod.outlook.com>
Date: Sun, 10 Nov 2024 08:37:39 +0000
From: Biju Das <biju.das.jz@...renesas.com>
To: Claudiu.Beznea <claudiu.beznea@...on.dev>, "geert+renesas@...der.be"
	<geert+renesas@...der.be>, "mturquette@...libre.com"
	<mturquette@...libre.com>, "sboyd@...nel.org" <sboyd@...nel.org>,
	"robh@...nel.org" <robh@...nel.org>, "krzk+dt@...nel.org"
	<krzk+dt@...nel.org>, "conor+dt@...nel.org" <conor+dt@...nel.org>, Prabhakar
 Mahadev Lad <prabhakar.mahadev-lad.rj@...renesas.com>, "lgirdwood@...il.com"
	<lgirdwood@...il.com>, "broonie@...nel.org" <broonie@...nel.org>,
	"magnus.damm@...il.com" <magnus.damm@...il.com>, "linus.walleij@...aro.org"
	<linus.walleij@...aro.org>, "perex@...ex.cz" <perex@...ex.cz>,
	"tiwai@...e.com" <tiwai@...e.com>, "p.zabel@...gutronix.de"
	<p.zabel@...gutronix.de>
CC: "linux-renesas-soc@...r.kernel.org" <linux-renesas-soc@...r.kernel.org>,
	"linux-clk@...r.kernel.org" <linux-clk@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-sound@...r.kernel.org" <linux-sound@...r.kernel.org>,
	"linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>, Claudiu.Beznea
	<claudiu.beznea@...on.dev>, Claudiu Beznea
	<claudiu.beznea.uj@...renesas.com>, "stable@...r.kernel.org"
	<stable@...r.kernel.org>
Subject: RE: [PATCH v2 06/25] ASoC: sh: rz-ssi: Terminate all the DMA
 transactions



> -----Original Message-----
> From: Claudiu <claudiu.beznea@...on.dev>
> Sent: 08 November 2024 10:50
> To: geert+renesas@...der.be; mturquette@...libre.com; sboyd@...nel.org; robh@...nel.org;
> krzk+dt@...nel.org; conor+dt@...nel.org; Biju Das <biju.das.jz@...renesas.com>; Prabhakar Mahadev Lad
> <prabhakar.mahadev-lad.rj@...renesas.com>; lgirdwood@...il.com; broonie@...nel.org;
> magnus.damm@...il.com; linus.walleij@...aro.org; perex@...ex.cz; tiwai@...e.com;
> p.zabel@...gutronix.de
> Cc: linux-renesas-soc@...r.kernel.org; linux-clk@...r.kernel.org; devicetree@...r.kernel.org; linux-
> kernel@...r.kernel.org; linux-sound@...r.kernel.org; linux-gpio@...r.kernel.org; Claudiu.Beznea
> <claudiu.beznea@...on.dev>; Claudiu Beznea <claudiu.beznea.uj@...renesas.com>; stable@...r.kernel.org
> Subject: [PATCH v2 06/25] ASoC: sh: rz-ssi: Terminate all the DMA transactions
> 
> From: Claudiu Beznea <claudiu.beznea.uj@...renesas.com>
> 
> In case of full duplex the 1st closed stream doesn't benefit from the dmaengine_terminate_async().
> Call it after the companion stream is closed.
> 
> Fixes: 26ac471c5354 ("ASoC: sh: rz-ssi: Add SSI DMAC support")

Maybe add fixes tag for full duplex case as the separation of 
Playback/ Capture is introduced in that patch.

> Cc: stable@...r.kernel.org
> Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@...renesas.com>

Reviewed-by: Biju Das <biju.das.jz@...renesas.com>

Cheers,
Biju

> ---
> 
> Changes in v2:
> - none
> 
>  sound/soc/renesas/rz-ssi.c | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/sound/soc/renesas/rz-ssi.c b/sound/soc/renesas/rz-ssi.c index 6efd017aaa7f..2d8721156099
> 100644
> --- a/sound/soc/renesas/rz-ssi.c
> +++ b/sound/soc/renesas/rz-ssi.c
> @@ -415,8 +415,12 @@ static int rz_ssi_stop(struct rz_ssi_priv *ssi, struct rz_ssi_stream *strm)
>  	rz_ssi_reg_mask_setl(ssi, SSICR, SSICR_TEN | SSICR_REN, 0);
> 
>  	/* Cancel all remaining DMA transactions */
> -	if (rz_ssi_is_dma_enabled(ssi))
> -		dmaengine_terminate_async(strm->dma_ch);
> +	if (rz_ssi_is_dma_enabled(ssi)) {
> +		if (ssi->playback.dma_ch)
> +			dmaengine_terminate_async(ssi->playback.dma_ch);
> +		if (ssi->capture.dma_ch)
> +			dmaengine_terminate_async(ssi->capture.dma_ch);
> +	}
> 
>  	rz_ssi_set_idle(ssi);
> 
> --
> 2.39.2