linux-kernel - Re: [PATCH v1 1/3] arm64: dts: marvell: Fix anyOf conditional failed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9B1A5D20-3DE5-40C1-8B2D-B1C4F53FA5F4@public-files.de>
Date: Sun, 10 Nov 2024 10:25:13 +0100
From: Frank Wunderlich <frank-w@...lic-files.de>
To: Andrew Lunn <andrew@...n.ch>, Frank Wunderlich <linux@...web.de>
CC: Damien Le Moal <dlemoal@...nel.org>, Niklas Cassel <cassel@...nel.org>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>,
 Gregory Clement <gregory.clement@...tlin.com>,
 Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>,
 Russell King <linux@...linux.org.uk>, Hans de Goede <hdegoede@...hat.com>,
 Jens Axboe <axboe@...nel.dk>, linux-ide@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v1 1/3] arm64: dts: marvell: Fix anyOf conditional failed

Am 9. November 2024 18:29:44 MEZ schrieb Andrew Lunn <andrew@...n.ch>:
>On Sat, Nov 09, 2024 at 10:46:19AM +0100, Frank Wunderlich wrote:
>> From: Frank Wunderlich <frank-w@...lic-files.de>
>> 
>> after converting the ahci-platform binding to yaml the following files
>> reporting "'anyOf' conditional failed" on
>> 
>> sata@...000: sata-port@0
>> diff --git a/arch/arm64/boot/dts/marvell/armada-7040-db.dts b/arch/arm64/boot/dts/marvell/armada-7040-db.dts
>> index 1e0ab35cc686..2b5e45d2c5a6 100644
>> --- a/arch/arm64/boot/dts/marvell/armada-7040-db.dts
>> +++ b/arch/arm64/boot/dts/marvell/armada-7040-db.dts
>> @@ -214,6 +214,7 @@ &cp0_sata0 {
>>  
>>  	sata-port@1 {
>>  		phys = <&cp0_comphy3 1>;
>> +		status = "okay";
>>  	};
>>  };
>
>>  
>> diff --git a/arch/arm64/boot/dts/marvell/armada-7040-mochabin.dts b/arch/arm64/boot/dts/marvell/armada-7040-mochabin.dts
>> index 7af949092b91..6bdc4f1e6939 100644
>> --- a/arch/arm64/boot/dts/marvell/armada-7040-mochabin.dts
>> +++ b/arch/arm64/boot/dts/marvell/armada-7040-mochabin.dts
>> @@ -433,11 +433,13 @@ &cp0_sata0 {
>>  	/* 7 + 12 SATA connector (J24) */
>>  	sata-port@0 {
>>  		phys = <&cp0_comphy2 0>;
>> +		status = "okay";
>>  	};
>>  
>>  	/* M.2-2250 B-key (J39) */
>>  	sata-port@1 {
>>  		phys = <&cp0_comphy3 1>;
>> +		status = "okay";
>>  	};
>>  };
>> diff --git a/arch/arm64/boot/dts/marvell/armada-cp11x.dtsi b/arch/arm64/boot/dts/marvell/armada-cp11x.dtsi
>> index 7e595ac80043..161beec0b6b0 100644
>> --- a/arch/arm64/boot/dts/marvell/armada-cp11x.dtsi
>> +++ b/arch/arm64/boot/dts/marvell/armada-cp11x.dtsi
>> @@ -347,10 +347,12 @@ CP11X_LABEL(sata0): sata@...000 {
>>  
>>  			sata-port@0 {
>>  				reg = <0>;
>> +				status = "disabled";
>>  			};
>
>I don't know the yaml too well, but it is not obvious how adding a few 
>status = "disabled"; status = "okay"; fixes a "'anyOf' conditional failed".
>
>Maybe you can expand the explanation a bit?
>
>	Andrew

Hi angelo,

I guess the dtbs_check only checks required properties from yaml if the node is enabled.

As you know, phys that can supply different types (sata,usb,pcie,*gmii,...),but only one mode can be used per phy. So only one controller can be used with it,the other(s) can not. I do not know marvell,but there are similar in mediatek (xsphy) and rockchip (combphy).

From my PoV it makes sense to check only enabled nodes for required properties,but i do not know internals of dtbs_check. This patch is 2 years old and i only rebased it and run dtbs check with the others to have a clean result...i can test again without this one to check if anyOf is shown again.

regards Frank