linux-kernel - Re: [PATCH 2/2] scsi: ufs: exynos: remove superfluous function parameter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241112075332.lhssmh44a77uyvit@thinkpad>
Date: Tue, 12 Nov 2024 13:23:32 +0530
From: Manivannan Sadhasivam <manisadhasivam.linux@...il.com>
To: Tudor Ambarus <tudor.ambarus@...aro.org>
Cc: alim.akhtar@...sung.com, James.Bottomley@...senPartnership.com,
	martin.petersen@...cle.com, krzk@...nel.org,
	linux-scsi@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org,
	andre.draszik@...aro.org, kernel-team@...roid.com,
	willmcvicker@...gle.com
Subject: Re: [PATCH 2/2] scsi: ufs: exynos: remove superfluous function
 parameter

On Wed, Oct 30, 2024 at 10:27:15AM +0000, Tudor Ambarus wrote:
> The pointer to device can be obtained from ufs->hba->dev,
> remove superfluous function parameter.
> 
> Signed-off-by: Tudor Ambarus <tudor.ambarus@...aro.org>

Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>

- Mani

> ---
>  drivers/ufs/host/ufs-exynos.c | 4 ++--
>  drivers/ufs/host/ufs-exynos.h | 2 +-
>  2 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/ufs/host/ufs-exynos.c b/drivers/ufs/host/ufs-exynos.c
> index db89ebe48bcd..7e381ab1011d 100644
> --- a/drivers/ufs/host/ufs-exynos.c
> +++ b/drivers/ufs/host/ufs-exynos.c
> @@ -198,7 +198,7 @@ static inline void exynos_ufs_ungate_clks(struct exynos_ufs *ufs)
>  	exynos_ufs_ctrl_clkstop(ufs, false);
>  }
>  
> -static int exynosauto_ufs_drv_init(struct device *dev, struct exynos_ufs *ufs)
> +static int exynosauto_ufs_drv_init(struct exynos_ufs *ufs)
>  {
>  	struct exynos_ufs_uic_attr *attr = ufs->drv_data->uic_attr;
>  
> @@ -1424,7 +1424,7 @@ static int exynos_ufs_init(struct ufs_hba *hba)
>  	exynos_ufs_fmp_init(hba, ufs);
>  
>  	if (ufs->drv_data->drv_init) {
> -		ret = ufs->drv_data->drv_init(dev, ufs);
> +		ret = ufs->drv_data->drv_init(ufs);
>  		if (ret) {
>  			dev_err(dev, "failed to init drv-data\n");
>  			goto out;
> diff --git a/drivers/ufs/host/ufs-exynos.h b/drivers/ufs/host/ufs-exynos.h
> index 1646c4a9bb08..9670dc138d1e 100644
> --- a/drivers/ufs/host/ufs-exynos.h
> +++ b/drivers/ufs/host/ufs-exynos.h
> @@ -182,7 +182,7 @@ struct exynos_ufs_drv_data {
>  	unsigned int quirks;
>  	unsigned int opts;
>  	/* SoC's specific operations */
> -	int (*drv_init)(struct device *dev, struct exynos_ufs *ufs);
> +	int (*drv_init)(struct exynos_ufs *ufs);
>  	int (*pre_link)(struct exynos_ufs *ufs);
>  	int (*post_link)(struct exynos_ufs *ufs);
>  	int (*pre_pwr_change)(struct exynos_ufs *ufs,
> -- 
> 2.47.0.199.ga7371fff76-goog
> 
> 

-- 
மணிவண்ணன் சதாசிவம்