linux-kernel - Re: [PATCH 1/2] scsi: ufs: exynos: remove empty drv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20241112075312.v3ir4ewg4kglckpf@thinkpad>
Date: Tue, 12 Nov 2024 13:23:12 +0530
From: Manivannan Sadhasivam <manisadhasivam.linux@...il.com>
To: Tudor Ambarus <tudor.ambarus@...aro.org>
Cc: alim.akhtar@...sung.com, James.Bottomley@...senPartnership.com,
	martin.petersen@...cle.com, krzk@...nel.org,
	linux-scsi@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org,
	andre.draszik@...aro.org, kernel-team@...roid.com,
	willmcvicker@...gle.com
Subject: Re: [PATCH 1/2] scsi: ufs: exynos: remove empty drv_init method

On Wed, Oct 30, 2024 at 10:27:14AM +0000, Tudor Ambarus wrote:
> Remove empty method. When the method is not set, the call is not made,
> saving a few cycles.
> 
> Signed-off-by: Tudor Ambarus <tudor.ambarus@...aro.org>

Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>

- Mani

> ---
>  drivers/ufs/host/ufs-exynos.c | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/drivers/ufs/host/ufs-exynos.c b/drivers/ufs/host/ufs-exynos.c
> index 9ec318ef52bf..db89ebe48bcd 100644
> --- a/drivers/ufs/host/ufs-exynos.c
> +++ b/drivers/ufs/host/ufs-exynos.c
> @@ -198,11 +198,6 @@ static inline void exynos_ufs_ungate_clks(struct exynos_ufs *ufs)
>  	exynos_ufs_ctrl_clkstop(ufs, false);
>  }
>  
> -static int exynos7_ufs_drv_init(struct device *dev, struct exynos_ufs *ufs)
> -{
> -	return 0;
> -}
> -
>  static int exynosauto_ufs_drv_init(struct device *dev, struct exynos_ufs *ufs)
>  {
>  	struct exynos_ufs_uic_attr *attr = ufs->drv_data->uic_attr;
> @@ -2036,7 +2031,6 @@ static const struct exynos_ufs_drv_data exynos_ufs_drvs = {
>  				  EXYNOS_UFS_OPT_BROKEN_RX_SEL_IDX |
>  				  EXYNOS_UFS_OPT_SKIP_CONNECTION_ESTAB |
>  				  EXYNOS_UFS_OPT_USE_SW_HIBERN8_TIMER,
> -	.drv_init		= exynos7_ufs_drv_init,
>  	.pre_link		= exynos7_ufs_pre_link,
>  	.post_link		= exynos7_ufs_post_link,
>  	.pre_pwr_change		= exynos7_ufs_pre_pwr_change,
> -- 
> 2.47.0.199.ga7371fff76-goog
> 
> 

-- 
மணிவண்ணன் சதாசிவம்