linux-kernel - Re: [PATCH] clk: qcom: remove unused data from gcc-ipq5424.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9297bd0e-f972-41fb-82ab-a4428a64135b@quicinc.com>
Date: Tue, 12 Nov 2024 14:15:35 +0530
From: Sricharan Ramabadhran <quic_srichara@...cinc.com>
To: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
        Arnd Bergmann
	<arnd@...nel.org>
CC: Bjorn Andersson <andersson@...nel.org>,
        Michael Turquette
	<mturquette@...libre.com>,
        Stephen Boyd <sboyd@...nel.org>,
        "Varadarajan
 Narayanan" <quic_varada@...cinc.com>,
        Arnd Bergmann <arnd@...db.de>,
        "Krzysztof Kozlowski" <krzysztof.kozlowski@...aro.org>,
        Manikanta Mylavarapu
	<quic_mmanikan@...cinc.com>,
        <linux-arm-msm@...r.kernel.org>, <linux-clk@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] clk: qcom: remove unused data from gcc-ipq5424.c

Hi Arnd,

On 11/11/2024 6:11 PM, Dmitry Baryshkov wrote:
> On Mon, Nov 11, 2024 at 11:32:51AM +0100, Arnd Bergmann wrote:
>> From: Arnd Bergmann <arnd@...db.de>
>>
>> The newly added driver causes a warnings when enabling -Wunused-const-variables:
>>
>> drivers/clk/qcom/gcc-ipq5424.c:1064:30: error: 'ftbl_gcc_q6_axi_clk_src' defined but not used [-Werror=unused-const-variable=]
>>   1064 | static const struct freq_tbl ftbl_gcc_q6_axi_clk_src[] = {
>>        |                              ^~~~~~~~~~~~~~~~~~~~~~~
>> drivers/clk/qcom/gcc-ipq5424.c:957:30: error: 'ftbl_gcc_qpic_clk_src' defined but not used [-Werror=unused-const-variable=]
>>    957 | static const struct freq_tbl ftbl_gcc_qpic_clk_src[] = {
>>        |                              ^~~~~~~~~~~~~~~~~~~~~
>> drivers/clk/qcom/gcc-ipq5424.c:497:30: error: 'ftbl_gcc_qupv3_2x_core_clk_src' defined but not used [-Werror=unused-const-variable=]
>>    497 | static const struct freq_tbl ftbl_gcc_qupv3_2x_core_clk_src[] = {
>>        |                              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>>
>> In order to hopefully enable this warning by default in the future,
>> remove the data for now. If it gets used in the future, it can
>> trivially get added back.
>>
>> Fixes: 21b5d5a4a311 ("clk: qcom: add Global Clock controller (GCC) driver for IPQ5424 SoC")
>> Signed-off-by: Arnd Bergmann <arnd@...db.de>
>> ---
>>   drivers/clk/qcom/gcc-ipq5424.c | 18 ------------------
>>   1 file changed, 18 deletions(-)
>>
> 
> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
> 

I already posted a patch here for fixing this [1]

[1] 
https://lore.kernel.org/lkml/xvkvhu3qvlsjnlkiinbm6wguttpozyvlyy5mbbjcpg7vnhrp7w@trjvrm2zpylk/

Regards,
  Sricharan