linux-kernel - Re: [PATCH][next] mm: shmem: Fix error checking on utf8_parse

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <13db01a1-1c8b-4d56-ac2d-9f39082c2644@gmail.com>
Date: Tue, 12 Nov 2024 10:12:24 +0000
From: "Colin King (gmail)" <colin.i.king@...il.com>
To: André Almeida <andrealmeid@...lia.com>
Cc: Hugh Dickins <hughd@...gle.com>, linux-mm@...ck.org,
 Christian Brauner <brauner@...nel.org>,
 Gabriel Krisman Bertazi <gabriel@...sman.be>,
 Andrew Morton <akpm@...ux-foundation.org>, kernel-janitors@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH][next] mm: shmem: Fix error checking on utf8_parse_version
 failures

On 12/11/2024 10:06, André Almeida wrote:
> Hi Colin,
> 
> Em 12/11/2024 06:54, Colin Ian King escreveu:
>> Currently the error check on the call to utf8_parse_version is always
>> false because version is an unsigned int and this can never be less
>> than zero. Because version is required to be an unsigned int, fix the
>> issue by casting it to int just for the error check.
> 
> Why is it required to be an unsigned int?

It's being passed to various functions that expect unsigned int, so I 
presume it was intended to be of that type.

Colin

> 
>>
>> Fixes: 58e55efd6c72 ("tmpfs: Add casefold lookup support")
>> Signed-off-by: Colin Ian King <colin.i.king@...il.com>
> 
> Another fix was already sent: https://lore.kernel.org/lkml/20241111- 
> unsignedcompare1601569-v1-1-c4a9c3c75a52@...il.com/