linux-kernel - Re: [PATCH] drivers: core: clear wake irq in device_unbind

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2024111207-baggie-eskimo-d2b0@gregkh>
Date: Tue, 12 Nov 2024 12:41:44 +0100
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: "Peng Fan (OSS)" <peng.fan@....nxp.com>
Cc: "Rafael J. Wysocki" <rafael@...nel.org>,
	open list <linux-kernel@...r.kernel.org>,
	Peng Fan <peng.fan@....com>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Rob Herring <robh@...nel.org>, Ulf Hansson <ulf.hansson@...aro.org>
Subject: Re: [PATCH] drivers: core: clear wake irq in device_unbind_cleanup

On Mon, Nov 11, 2024 at 05:21:30PM +0800, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@....com>
> 
> With dev_pm_clear_wake_irq in device_unbind_cleanup, there is no need
> to invoke dev_pm_clear_wake_irq in driver remove hook explicitly.
> 
> Cc: Dmitry Torokhov <dmitry.torokhov@...il.com>
> Cc: Rob Herring <robh@...nel.org>
> Cc: Ulf Hansson <ulf.hansson@...aro.org>
> Signed-off-by: Peng Fan <peng.fan@....com>
> ---
>  drivers/base/dd.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/base/dd.c b/drivers/base/dd.c
> index f0e4b4aba885..ea3a871bdd11 100644
> --- a/drivers/base/dd.c
> +++ b/drivers/base/dd.c
> @@ -26,6 +26,7 @@
>  #include <linux/wait.h>
>  #include <linux/async.h>
>  #include <linux/pm_runtime.h>
> +#include <linux/pm_wakeirq.h>
>  #include <linux/pinctrl/devinfo.h>
>  #include <linux/slab.h>
>  
> @@ -556,6 +557,7 @@ static void device_unbind_cleanup(struct device *dev)
>  		dev->pm_domain->dismiss(dev);
>  	pm_runtime_reinit(dev);
>  	dev_pm_set_driver_flags(dev, 0);
> +	dev_pm_clear_wake_irq(dev);

I don't understand, you say you don't need to invoke it, yet you are
calling it here.

What commit id does this fix?  And what bug is this resolving?  What
drivers are broken without this?

thanks,

greg k-h