linux-kernel - Re: [PATCH] serial: amba-pl011: Fix RX stall when DMA is used

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202411140119.QKkmNN97-lkp@intel.com>
Date: Thu, 14 Nov 2024 01:57:55 +0800
From: kernel test robot <lkp@...el.com>
To: Kartik <kkartik@...dia.com>, linux@...linux.org.uk,
	gregkh@...uxfoundation.org, jirislaby@...nel.org,
	theo.lebrun@...tlin.com, linus.walleij@...aro.org,
	ilpo.jarvinen@...ux.intel.com, l.sanfilippo@...bus.com,
	konradybcio@...nel.org, christophe.jaillet@...adoo.fr,
	arnd@...db.de, linux-kernel@...r.kernel.org,
	linux-serial@...r.kernel.org
Cc: oe-kbuild-all@...ts.linux.dev
Subject: Re: [PATCH] serial: amba-pl011: Fix RX stall when DMA is used

Hi Kartik,

kernel test robot noticed the following build errors:

[auto build test ERROR on tty/tty-testing]
[also build test ERROR on tty/tty-next tty/tty-linus usb/usb-testing usb/usb-next usb/usb-linus soc/for-next linus/master v6.12-rc7 next-20241113]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Kartik/serial-amba-pl011-Fix-RX-stall-when-DMA-is-used/20241113-131203
base:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git tty-testing
patch link:    https://lore.kernel.org/r/20241113051023.3125-1-kkartik%40nvidia.com
patch subject: [PATCH] serial: amba-pl011: Fix RX stall when DMA is used
config: arm64-randconfig-003-20241113 (https://download.01.org/0day-ci/archive/20241114/202411140119.QKkmNN97-lkp@intel.com/config)
compiler: aarch64-linux-gcc (GCC) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241114/202411140119.QKkmNN97-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202411140119.QKkmNN97-lkp@intel.com/

All errors (new ones prefixed by >>):

   drivers/tty/serial/amba-pl011.c: In function 'pl011_unthrottle_rx':
>> drivers/tty/serial/amba-pl011.c:1822:16: error: 'struct uart_amba_port' has no member named 'using_rx_dma'
    1822 |         if (uap->using_rx_dma) {
         |                ^~
>> drivers/tty/serial/amba-pl011.c:1823:20: error: 'struct uart_amba_port' has no member named 'dmacr'
    1823 |                 uap->dmacr |= UART011_RXDMAE;
         |                    ^~
   drivers/tty/serial/amba-pl011.c:1824:32: error: 'struct uart_amba_port' has no member named 'dmacr'
    1824 |                 pl011_write(uap->dmacr, uap, REG_DMACR);
         |                                ^~


vim +1822 drivers/tty/serial/amba-pl011.c

  1808	
  1809	static void pl011_unthrottle_rx(struct uart_port *port)
  1810	{
  1811		struct uart_amba_port *uap = container_of(port, struct uart_amba_port, port);
  1812		unsigned long flags;
  1813	
  1814		uart_port_lock_irqsave(&uap->port, &flags);
  1815	
  1816		uap->im = UART011_RTIM;
  1817		if (!pl011_dma_rx_running(uap))
  1818			uap->im |= UART011_RXIM;
  1819	
  1820		pl011_write(uap->im, uap, REG_IMSC);
  1821	
> 1822		if (uap->using_rx_dma) {
> 1823			uap->dmacr |= UART011_RXDMAE;
  1824			pl011_write(uap->dmacr, uap, REG_DMACR);
  1825		}
  1826	
  1827		uart_port_unlock_irqrestore(&uap->port, flags);
  1828	}
  1829	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki