linux-kernel - Re: [PATCH] serial: amba-pl011: Fix RX stall when DMA is used

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2024111318-clang-chute-a7f4@gregkh>
Date: Wed, 13 Nov 2024 06:31:49 +0100
From: Greg KH <gregkh@...uxfoundation.org>
To: Kartik <kkartik@...dia.com>
Cc: linux@...linux.org.uk, jirislaby@...nel.org, theo.lebrun@...tlin.com,
	linus.walleij@...aro.org, ilpo.jarvinen@...ux.intel.com,
	l.sanfilippo@...bus.com, konradybcio@...nel.org,
	christophe.jaillet@...adoo.fr, arnd@...db.de,
	linux-kernel@...r.kernel.org, linux-serial@...r.kernel.org
Subject: Re: [PATCH] serial: amba-pl011: Fix RX stall when DMA is used

On Wed, Nov 13, 2024 at 10:40:23AM +0530, Kartik wrote:
> Function pl011_throttle_rx() calls pl011_stop_rx() to disable RX, which
> also disables the RX DMA by clearing the RXDMAE bit of the DMACR
> register. However, to properly unthrottle RX when DMA is used, the
> function pl011_unthrottle_rx() is expected to set the RXDMAE bit of
> the DMACR register, which it currently lacks. This causes RX to stall
> after the throttle API is called.
> 
> Set RXDMAE bit in the DMACR register while unthrottling RX if RX DMA is
> used.
> 
> Fixes: 211565b10099 ("serial: pl011: UPSTAT_AUTORTS requires .throttle/unthrottle")
> Signed-off-by: Kartik <kkartik@...dia.com>
> ---
>  drivers/tty/serial/amba-pl011.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/tty/serial/amba-pl011.c b/drivers/tty/serial/amba-pl011.c
> index 4c4b0d470c65..f40714685166 100644
> --- a/drivers/tty/serial/amba-pl011.c
> +++ b/drivers/tty/serial/amba-pl011.c
> @@ -1819,6 +1819,11 @@ static void pl011_unthrottle_rx(struct uart_port *port)
>  
>  	pl011_write(uap->im, uap, REG_IMSC);
>  
> +	if (uap->using_rx_dma) {
> +		uap->dmacr |= UART011_RXDMAE;
> +		pl011_write(uap->dmacr, uap, REG_DMACR);
> +	}
> +
>  	uart_port_unlock_irqrestore(&uap->port, flags);
>  }
>  
> -- 
> 2.47.0
> 
> 

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- It looks like you did not use your "real" name for the patch on either
  the Signed-off-by: line, or the From: line (both of which have to
  match).  Please read the kernel file,
  Documentation/process/submitting-patches.rst for how to do this
  correctly.

- You have marked a patch with a "Fixes:" tag for a commit that is in an
  older released kernel, yet you do not have a cc: stable line in the
  signed-off-by area at all, which means that the patch will not be
  applied to any older kernel releases.  To properly fix this, please
  follow the documented rules in the
  Documentation/process/stable-kernel-rules.rst file for how to resolve
  this.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot