linux-kernel - Re: [PATCH v5 02/28] media: iris: add platform driver for iris video device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0b6fea6c-4144-09e3-bf83-3844f00138d4@quicinc.com>
Date: Wed, 13 Nov 2024 10:37:22 +0530
From: Dikshita Agarwal <quic_dikshita@...cinc.com>
To: Bryan O'Donoghue <bryan.odonoghue@...aro.org>,
        Vikash Garodia
	<quic_vgarodia@...cinc.com>,
        Abhinav Kumar <quic_abhinavk@...cinc.com>,
        "Mauro Carvalho Chehab" <mchehab@...nel.org>,
        Rob Herring <robh@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Philipp Zabel <p.zabel@...gutronix.de>
CC: Hans Verkuil <hverkuil@...all.nl>,
        Sebastian Fricke
	<sebastian.fricke@...labora.com>,
        Dmitry Baryshkov
	<dmitry.baryshkov@...aro.org>,
        Neil Armstrong <neil.armstrong@...aro.org>,
        Nicolas Dufresne <nicolas@...fresne.ca>,
        Uwe Kleine-König
	<u.kleine-koenig@...libre.com>,
        Jianhua Lu <lujianhua000@...il.com>, <linux-media@...r.kernel.org>,
        <linux-arm-msm@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v5 02/28] media: iris: add platform driver for iris video
 device



On 11/9/2024 11:02 PM, Bryan O'Donoghue wrote:
> On 05/11/2024 06:55, Dikshita Agarwal wrote:
>> In preparation of adding H264 decode functionality, add probe and remove
>> functions and platform data to initialize iris resources, which are
>> clocks, interconnects, power domains, reset clocks, and clock
>> frequencies used for iris hardware.
>>
>> Signed-off-by: Dikshita Agarwal <quic_dikshita@...cinc.com>
>> ---
>>   drivers/media/platform/qcom/Kconfig                |   1 +
>>   drivers/media/platform/qcom/Makefile               |   1 +
>>   drivers/media/platform/qcom/iris/Kconfig           |   9 +
>>   drivers/media/platform/qcom/iris/Makefile          |   4 +
>>   drivers/media/platform/qcom/iris/iris_core.h       |  54 +++++
>>   .../platform/qcom/iris/iris_platform_common.h      |  35 +++
>>   .../platform/qcom/iris/iris_platform_sm8550.c      |  37 ++++
>>   drivers/media/platform/qcom/iris/iris_probe.c      | 237
>> +++++++++++++++++++++
>>   8 files changed, 378 insertions(+)
>>
>> diff --git a/drivers/media/platform/qcom/Kconfig
>> b/drivers/media/platform/qcom/Kconfig
>> index cc5799b9ea00..4f4d3a68e6e5 100644
>> --- a/drivers/media/platform/qcom/Kconfig
>> +++ b/drivers/media/platform/qcom/Kconfig
>> @@ -3,4 +3,5 @@
>>   comment "Qualcomm media platform drivers"
>>     source "drivers/media/platform/qcom/camss/Kconfig"
>> +source "drivers/media/platform/qcom/iris/Kconfig"
>>   source "drivers/media/platform/qcom/venus/Kconfig"
>> diff --git a/drivers/media/platform/qcom/Makefile
>> b/drivers/media/platform/qcom/Makefile
>> index 4f055c396e04..ea2221a202c0 100644
>> --- a/drivers/media/platform/qcom/Makefile
>> +++ b/drivers/media/platform/qcom/Makefile
>> @@ -1,3 +1,4 @@
>>   # SPDX-License-Identifier: GPL-2.0-only
>>   obj-y += camss/
>> +obj-y += iris/
>>   obj-y += venus/
>> diff --git a/drivers/media/platform/qcom/iris/Kconfig
>> b/drivers/media/platform/qcom/iris/Kconfig
>> new file mode 100644
>> index 000000000000..34a2f81c5db3
>> --- /dev/null
>> +++ b/drivers/media/platform/qcom/iris/Kconfig
>> @@ -0,0 +1,9 @@
>> +config VIDEO_QCOM_IRIS
>> +        tristate "Qualcomm iris V4L2 decoder driver"
>> +        depends on VIDEO_DEV
>> +        depends on ARCH_QCOM || COMPILE_TEST
>> +        help
>> +          This is a V4L2 driver for Qualcomm iris video accelerator
>> +          hardware. It accelerates decoding operations on various
>> +          Qualcomm SoCs.
>> +          To compile this driver as a module choose m here.
>> diff --git a/drivers/media/platform/qcom/iris/Makefile
>> b/drivers/media/platform/qcom/iris/Makefile
>> new file mode 100644
>> index 000000000000..7e701361492e
>> --- /dev/null
>> +++ b/drivers/media/platform/qcom/iris/Makefile
>> @@ -0,0 +1,4 @@
>> +iris-objs += iris_platform_sm8550.o \
>> +             iris_probe.o \
>> +
>> +obj-$(CONFIG_VIDEO_QCOM_IRIS) += iris.o
>> diff --git a/drivers/media/platform/qcom/iris/iris_core.h
>> b/drivers/media/platform/qcom/iris/iris_core.h
>> new file mode 100644
>> index 000000000000..dd0e2650641a
>> --- /dev/null
>> +++ b/drivers/media/platform/qcom/iris/iris_core.h
>> @@ -0,0 +1,54 @@
>> +/* SPDX-License-Identifier: GPL-2.0-only */
>> +/*
>> + * Copyright (c) 2022-2024 Qualcomm Innovation Center, Inc. All rights
>> reserved.
>> + */
>> +
>> +#ifndef _IRIS_CORE_H_
>> +#define _IRIS_CORE_H_
> 
> Its more usual to do two underscores __LIKE_SO__
> 
Noted.

Thanks,
Dikshita
> Once amended.
> 
> Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@...aro.org>
> 
> Please remember to similarly update other headers in your series.
> 
> ---
> bod